Add --feature readonly, to build a bin without risky commands

```
> cargo build --features readonly && sudo ./target/debug/framework_tool --dump-ec-flash ec.bin && ls -l ec.bin
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
ls: cannot access 'ec.bin': No such file or directory

> cargo build && sudo ./target/debug/framework_tool --dump-ec-flash ec.bin && ls -l ec.bin
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
Dumping to ec.bin
-rw-r--r--. 1 root root 524288 May 10 09:24 ec.bin
```

Signed-off-by: Daniel Schaefer <[email protected]>

Author: JohnAZoidberg

framework_lib/Cargo.toml

@@ -9,6 +9,7 @@ build = "build.rs"
 
 [features]
 default = ["hidapi", "rusb"]
+readonly = [ ]
 rusb = ["dep:rusb"]
 hidapi = ["dep:hidapi"]
 uefi = [ "lazy_static/spin_no_std" ]

framework_lib/src/commandline/mod.rs

@@ -212,9 +212,75 @@ pub struct Cli {
 
 pub fn parse(args: &[String]) -> Cli {
     #[cfg(feature = "uefi")]
-    return uefi::parse(args);
+    let cli = uefi::parse(args);
     #[cfg(not(feature = "uefi"))]
-    return clap_std::parse(args);
+    let cli = clap_std::parse(args);
+
+    if cfg!(feature = "readonly") {
+        // Initialize a new Cli with no arguments
+        let mut safe_cli = Cli::default();
+
+        // Copy all arguments that are readonly/safe
+        // We explicitly only cope the safe ones so that if we add new arguments in the future,
+        // which might be unsafe, we can't forget to exclude them from the safe set.
+        // TODO: Instead of silently ignoring blocked command, we should remind the user
+        safe_cli.verbosity = cli.verbosity;
+        safe_cli.versions = cli.versions;
+        safe_cli.version = cli.version;
+        safe_cli.esrt = cli.esrt;
+        safe_cli.device = cli.device;
+        safe_cli.power = cli.power;
+        safe_cli.thermal = cli.thermal;
+        safe_cli.sensors = cli.sensors;
+        // fansetduty
+        // fansetrpm
+        // autofanctrl
+        safe_cli.privacy = cli.privacy;
+        safe_cli.pd_info = cli.version;
+        safe_cli.dp_hdmi_info = cli.dp_hdmi_info;
+        // dp_hdmi_update
+        safe_cli.audio_card_info = cli.audio_card_info;
+        safe_cli.pd_bin = cli.pd_bin;
+        safe_cli.ec_bin = cli.ec_bin;
+        safe_cli.capsule = cli.capsule;
+        safe_cli.dump = cli.dump;
+        safe_cli.h2o_capsule = cli.h2o_capsule;
+        // dump_ec_flash
+        // flash_ec
+        // flash_ro_ec
+        safe_cli.driver = cli.driver;
+        safe_cli.test = cli.test;
+        safe_cli.intrusion = cli.intrusion;
+        safe_cli.inputdeck = cli.inputdeck;
+        safe_cli.inputdeck_mode = cli.inputdeck_mode;
+        safe_cli.expansion_bay = cli.expansion_bay;
+        // charge_limit
+        // charge_current_limit
+        safe_cli.get_gpio = cli.get_gpio;
+        safe_cli.fp_led_level = cli.fp_led_level;
+        safe_cli.fp_brightness = cli.fp_brightness;
+        safe_cli.kblight = cli.kblight;
+        safe_cli.rgbkbd = cli.rgbkbd;
+        // tablet_mode
+        // touchscreen_enable
+        safe_cli.stylus_battery = cli.stylus_battery;
+        safe_cli.console = cli.console;
+        safe_cli.reboot_ec = cli.reboot_ec;
+        // ec_hib_delay
+        safe_cli.hash = cli.hash;
+        safe_cli.pd_addrs = cli.pd_addrs;
+        safe_cli.pd_ports = cli.pd_ports;
+        safe_cli.help = cli.help;
+        safe_cli.info = cli.info;
+        // allupdate
+        safe_cli.paginate = cli.paginate;
+        safe_cli.intrusion = cli.intrusion;
+        // raw_command
+
+        safe_cli
+    } else {
+        cli
+    }
 }
 
 fn print_single_pd_details(pd: &PdController) {

framework_tool/Cargo.toml

@@ -3,6 +3,10 @@ name = "framework_tool"
 version = "0.4.1"
 edition = "2021"
 
+[features]
+default = [ ]
+readonly = [ "framework_lib/readonly" ]
+
 [dependencies.framework_lib]
 path = "../framework_lib"
 

framework_uefi/Cargo.toml

@@ -9,6 +9,10 @@ rust-version = "1.74"
 name = "uefitool"
 path = "src/main.rs"
 
+[features]
+default = [ ]
+readonly = [ "framework_lib/readonly" ]
+
 [dependencies]
 uefi = { version = "0.20", features = ["alloc"] }
 uefi-services = "0.17"