Skip to content

Commit e7a33c2

Browse files
committed
Rename some build rules to meet expectation in JGit bazel build
This is a preparation to link JGit as a submodule instead of an external Maven build dependency. Change-Id: Icd470c32b6b0447b480bc494ea5ebf558c24e34c
1 parent 9f97b8b commit e7a33c2

File tree

7 files changed

+23
-28
lines changed

7 files changed

+23
-28
lines changed

BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ pkg_war(
66
libs = [
77
"//lib/jetty:server",
88
"//lib/jetty:servlet",
9-
"//lib/slf4j:slf4j-simple",
9+
"//lib:slf4j-simple",
1010
"//java/com/google/gitiles:servlet",
1111
],
1212
web_xml = "//resources:web_xml",

WORKSPACE

+3-3
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ maven_jar(
106106
)
107107

108108
maven_jar(
109-
name = "servlet-api_3_1",
109+
name = "servlet-api",
110110
artifact = "javax.servlet:javax.servlet-api:3.1.0",
111111
sha1 = "3cd63d075497751784b2fa84be59432f4905bf7c",
112112
)
@@ -181,7 +181,7 @@ maven_jar(
181181
)
182182

183183
maven_jar(
184-
name = "ewah",
184+
name = "javaewah",
185185
artifact = "com.googlecode.javaewah:JavaEWAH:1.1.7",
186186
sha1 = "570dde3cd706ae10c62fe19b150928cfdb415e87",
187187
)
@@ -218,7 +218,7 @@ maven_jar(
218218
SL_VERS = "1.7.26"
219219

220220
maven_jar(
221-
name = "slf4j-api",
221+
name = "log-api",
222222
artifact = "org.slf4j:slf4j-api:" + SL_VERS,
223223
sha1 = "77100a62c2e6f04b53977b9f541044d7d722693d",
224224
)

java/com/google/gitiles/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ DEPS = [
1717
"//lib:prettify",
1818
"//lib/jgit:jgit",
1919
"//lib/jgit:jgit-servlet",
20-
"//lib/slf4j:slf4j-api",
20+
"//lib:slf4j-api",
2121
"//lib/soy:soy",
2222
"//java/com/google/gitiles/blame/cache",
2323
]

java/com/google/gitiles/dev/BUILD

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ java_library(
99
"//lib:guava",
1010
"//lib:guava-failureaccess",
1111
"//lib:html-types",
12-
"//lib:servlet-api_3_1",
12+
"//lib:servlet-api",
1313
"//lib/jetty:server",
1414
"//lib/jetty:servlet",
1515
"//lib/jgit",
1616
"//lib/jgit:jgit-servlet",
17-
"//lib/slf4j:slf4j-api",
18-
"//lib/slf4j:slf4j-simple",
17+
"//lib:slf4j-api",
18+
"//lib:slf4j-simple",
1919
"//lib/soy",
2020
],
2121
)

lib/BUILD

+14-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package(
1818
"html-types",
1919
"jsr305",
2020
"servlet-api_2_5",
21-
"servlet-api_3_1",
21+
"servlet-api",
2222
"gson",
2323
"guava",
2424
"guava-failureaccess",
@@ -29,3 +29,16 @@ package(
2929
"ow2-asm-tree",
3030
"ow2-asm-util",
3131
]]
32+
33+
java_library(
34+
name = "slf4j-api",
35+
exports = ["@log-api//jar"],
36+
)
37+
38+
java_library(
39+
name = "slf4j-simple",
40+
runtime_deps = [
41+
":slf4j-api",
42+
"@slf4j-simple//jar",
43+
],
44+
)

lib/jetty/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ java_library(
88
name = "servlet",
99
exports = [
1010
":security",
11-
"//lib:servlet-api_3_1", # Different from the rest of gitiles-server.
11+
"//lib:servlet-api", # Different from the rest of gitiles-server.
1212
"@servlet//jar",
1313
],
1414
)

lib/slf4j/BUILD

-18
This file was deleted.

0 commit comments

Comments
 (0)