remove!: url parsing error NotALocalFile

The `NotALocalFile` error variant was previously returned if the input
url contained a colon but the slice after that character contained no
slash character (`/` or `\`). This behavior is wrong.

SCP like URLs may not need a slash character to specify the repositories
location. Similarly, a local directory that contains a colon in its name
is a valid repository path as well.

The new implementation correctly parses such URLs.

Author: niklaswimmer

gix-url/src/parse/mod.rs

@@ -11,8 +11,6 @@ pub enum Error {
     Url(#[from] url::ParseError),
     #[error("file URLs require an absolute or relative path to the repository")]
     MissingRepositoryPath,
-    #[error("\"{url}\" is not a valid local path")]
-    NotALocalFile { url: BString },
     #[error("Relative URLs are not permitted: {url:?}")]
     RelativeUrl { url: String },
 }

gix-url/tests/parse/file.rs

@@ -142,6 +142,17 @@ fn url_from_absolute_path() -> crate::Result {
     Ok(())
 }
 
+#[test]
+fn url_from_relative_path_with_colon_in_name() -> crate::Result {
+    let url = assert_url(
+        "./weird/directory/na:me",
+        url_alternate(Scheme::File, None, None, None, b"./weird/directory/na:me"),
+    )?
+    .to_bstring();
+    assert_eq!(url, "./weird/directory/na:me");
+    Ok(())
+}
+
 mod windows {
     use gix_url::Scheme;
 

gix-url/tests/parse/invalid.rs

@@ -41,8 +41,3 @@ fn empty() {
 fn missing_port_despite_indication() {
     assert_failure("ssh://host.xz:", Error::MissingRepositoryPath)
 }
-
-#[test]
-fn strange() {
-    assert_failure("file:..", "\"file:..\" is not a valid local path")
-}

gix-url/tests/parse/ssh.rs

@@ -177,3 +177,13 @@ fn strange_windows_paths_yield_meaningful_results() -> crate::Result {
     assert_eq!(url, "[email protected]:42:C:/strange/absolute/path");
     Ok(())
 }
+
+// Git does not care that the host is named `file`, it still treats it as an SCP url.
+// I btw tested this, yes you can really clone a repository from there, just `git init`
+// in the directory above your home directory on the remote machine.
+#[test]
+fn strange() -> crate::Result {
+    let url = assert_url("file:..", url_alternate(Scheme::Ssh, None, "file", None, b".."))?.to_bstring();
+    assert_eq!(url, "file:..");
+    Ok(())
+}