Skip to content

Storybook: Differences in RTL between the app and storybook #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samwhale opened this issue Mar 17, 2021 · 0 comments
Closed

Storybook: Differences in RTL between the app and storybook #6809

samwhale opened this issue Mar 17, 2021 · 0 comments
Labels
Group: Design System Internationalization (I18N) P3 Nice to have Type: Bug Something isn't working Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@samwhale
Copy link
Contributor

Bug Description

Storybook sometimes applies RTL (Right-to-left) styles differently than the editor and dashboard do.

Expected Behaviour

RTL styling in storybook should match the styles seen in the dashboard and editor.

Steps to Reproduce

  1. Go to storybook
  2. Go to the Switch component
  3. Click the RTL button in the toolbar
  4. See the wonky styles 😬

Screenshots

Storybook
rtl text color

Editor (Added the new switch component on top of the old switch component:
switch-wat

Additional Context

Discovered in #6799 - #6799 (comment).

  • Plugin Version: 1.5.0-alpha
  • WordPress Version: 5.7
  • Operating System: macOSX Big Sur 11.2.2
  • Browser: Google Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@samwhale samwhale added the Type: Bug Something isn't working label Mar 17, 2021
@samwhale samwhale mentioned this issue Mar 17, 2021
Merged
9 tasks
@swissspidy swissspidy added Pod: WP & Infra Type: Infrastructure Changes impacting testing infrastructure or build tooling P3 Nice to have labels Jun 28, 2021
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Design System Internationalization (I18N) P3 Nice to have Type: Bug Something isn't working Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swissspidy @BrittanyIRL @samwhale