We only ever report strings now

Author: Zac-HD

hypothesis-python/RELEASE.rst

@@ -0,0 +1,3 @@
+RELEASE_TYPE: patch
+
+Minor internal-only cleanups to some error-handling and reporting code.

hypothesis-python/src/hypothesis/reporting.py

@@ -8,8 +8,6 @@
 # v. 2.0. If a copy of the MPL was not distributed with this file, You can
 # obtain one at https://mozilla.org/MPL/2.0/.
 
-import inspect
-
 from hypothesis._settings import Verbosity, settings
 from hypothesis.internal.compat import escape_unicode_characters
 from hypothesis.utils.dynamicvariables import DynamicVariable
@@ -37,14 +35,6 @@ def current_verbosity():
     return settings.default.verbosity
 
 
-def to_text(textish):
-    if inspect.isfunction(textish):
-        textish = textish()
-    if isinstance(textish, bytes):
-        textish = textish.decode()
-    return textish
-
-
 def verbose_report(text):
     if current_verbosity() >= Verbosity.verbose:
         base_report(text)
@@ -61,4 +51,5 @@ def report(text):
 
 
 def base_report(text):
-    current_reporter()(to_text(text))
+    assert isinstance(text, str), f"unexpected non-str {text=}"
+    current_reporter()(text)

hypothesis-python/tests/cover/test_reporting.py

@@ -15,19 +15,12 @@
 
 from hypothesis import given, reporting
 from hypothesis._settings import Verbosity, settings
-from hypothesis.reporting import debug_report, report, verbose_report
+from hypothesis.reporting import debug_report, verbose_report
 from hypothesis.strategies import integers
 
 from tests.common.utils import capture_out
 
 
-def test_can_print_bytes():
-    with capture_out() as o:
-        with reporting.with_reporter(reporting.default):
-            report(b"hi")
-    assert o.getvalue() == "hi\n"
-
-
 def test_prints_output_by_default():
     @given(integers())
     def test_int(x):
@@ -77,10 +70,3 @@ def test_can_report_when_system_locale_is_ascii(monkeypatch):
         with open(write, "w", encoding="ascii") as write:
             monkeypatch.setattr(sys, "stdout", write)
             reporting.default("☃")
-
-
-def test_can_report_functions():
-    with capture_out() as out:
-        report(lambda: "foo")
-
-    assert out.getvalue().strip() == "foo"