Skip to content

Commit 71c6520

Browse files
committed
chore: better warning/debug messages on failing signature validations
1 parent 6d7eb6a commit 71c6520

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/cryptojwt/jws/jws.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,14 +226,13 @@ def verify_compact_verbose(self, jws=None, keys=None, allow_none=False, sigalg=N
226226
_key = key.key
227227

228228
try:
229-
if not verifier.verify(jwt.sign_input(), jwt.signature(), _key):
230-
continue
229+
verifier.verify(jwt.sign_input(), jwt.signature(), _key)
231230
except (BadSignature, IndexError):
232-
pass
231+
logger.warning(f'BadSignature caught with {jwt}: "{err}"')
233232
except (ValueError, TypeError) as err:
234-
logger.warning('Exception "{}" caught'.format(err))
233+
logger.warning(f'Exception with {jwt.headers}: "{err}"')
235234
else:
236-
logger.debug("Verified message using key with kid=%s" % key.kid)
235+
logger.debug(f"Verified message using key with kid={key.kid}")
237236
self.msg = jwt.payload()
238237
self.key = key
239238
self._protected_headers = jwt.headers.copy()

src/cryptojwt/jwt.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,8 @@ def unpack(self, token):
374374
else:
375375
_msg_cls = self.iss2msg_cls.get(_info["iss"], None)
376376
if not _msg_cls:
377-
LOGGER.warning(
378-
"Exception unpacking a received JWT "
377+
LOGGER.debug(
378+
"both msg_cls and iss2msg are None "
379379
f"for the issuer {_info['iss']}"
380380
)
381381

0 commit comments

Comments
 (0)