Rename values to fields

Because this is how they're called in InfluxDB.

Author: ChrisBr

README.md

@@ -25,7 +25,7 @@ Automatically instrument your Ruby on Rails applications and write the metrics d
 Add the gem to your `Gemfile`:
 
 ```console
-echo 'gem "influxdb-rails"' >>Gemfile
+echo 'gem "influxdb-rails"' >> Gemfile
 bundle install
 ```
 
@@ -50,7 +50,7 @@ Reported ActiveSupport instrumentation hooks:
 - [start\_processing.action\_controller](https://guides.rubyonrails.org/active_support_instrumentation.html#start-processing-action-controller)
 - [process\_action.action\_controller](https://guides.rubyonrails.org/active_support_instrumentation.html#process-action-action-controller)
 
-Reported values:
+Reported fields:
 
 ```ruby
   controller: 48.467,
@@ -83,7 +83,7 @@ Reported ActiveSupport instrumentation hooks:
 - [render\_partial.action\_view](https://guides.rubyonrails.org/active_support_instrumentation.html#render-partial-action-view)
 - [render\_collection.action\_view](https://guides.rubyonrails.org/active_support_instrumentation.html#render-collection-action-view)
 
-Reported values:
+Reported fields:
 
 ```ruby
   value: 48.467,
@@ -109,7 +109,7 @@ Reported ActiveSupport instrumentation hooks:
 - [sql.active\_record](https://guides.rubyonrails.org/active_support_instrumentation.html#sql-active-record)
 - [instantiation.active\_record](https://guides.rubyonrails.org/active_support_instrumentation.html#instantiation-active-record)
 
-Reported SQL values:
+Reported fields:
 
 ```ruby
   sql: "SELECT \"posts\".* FROM \"posts\"",
@@ -153,7 +153,7 @@ Reported ActiveSupport instrumentation hooks:
 - [enqueue.active\_job](https://guides.rubyonrails.org/active_support_instrumentation.html#enqueue-active-job)
 - [perform.active\_job](https://guides.rubyonrails.org/active_support_instrumentation.html#perform-active-job)
 
-Reported values:
+Reported fields:
 
 ```ruby
   value: 89.467
@@ -177,7 +177,7 @@ Reported ActiveSupport instrumentation hooks:
 
 - [deliver.action\_mailer](https://guides.rubyonrails.org/active_support_instrumentation.html#deliver-action-mailer)
 
-Reported values:
+Reported fields:
 
 ```ruby
   value: 1
@@ -194,12 +194,13 @@ Reported tags:
 
 ## Configuration
 
-The only setting you actually need to configure is the name of the database
-within the InfluxDB server instance (don't forget to create this database!).
+The only settings you actually need to configure are the organization, bucket and access token.
 
 ```ruby
 InfluxDB::Rails.configure do |config|
-  config.client.database = "rails"
+  config.client.org = "org"
+  config.client.bucket = "bucket"
+  config.client.token = "token"
 end
 ```
 
@@ -234,7 +235,7 @@ class ApplicationController
 
   def set_influx_data
     InfluxDB::Rails.current.tags = { user: current_user.id }
-    InfluxDB::Rails.current.values = { redis_value: redis_value }
+    InfluxDB::Rails.current.fields = { redis_value: redis_value }
   end
 end
 ```
@@ -243,7 +244,7 @@ end
 If you want to add custom instrumentation, you can wrap any code into a block instrumentation
 
 ```ruby
-InfluxDB::Rails.instrument "expensive_operation", tags: { }, values: { } do
+InfluxDB::Rails.instrument "expensive_operation", tags: { }, fields: { } do
   expensive_operation
 end
 ```
@@ -258,23 +259,23 @@ Reported tags:
   name:       "expensive_operation"
 ```
 
-Reported values:
+Reported fields:
 ```ruby
   value: 100 # execution time of the block in ms
 ```
 
 You can also overwrite the `value`
 
 ```ruby
-InfluxDB::Rails.instrument "user_count", values: { value: 1 } do
+InfluxDB::Rails.instrument "user_count", fields: { value: 1 } do
   User.create(name: 'mickey', surname: 'mouse')
 end
 ```
 
 or call it even without a block
 
 ```ruby
-InfluxDB::Rails.instrument "temperature", values: { value: 25 }
+InfluxDB::Rails.instrument "temperature", fields: { value: 25 }
 ```
 
 ### Custom client configuration
@@ -285,15 +286,17 @@ to your InfluxDB server. You can access this client as well, and perform
 arbitrary operations on your data:
 
 ```ruby
-InfluxDB::Rails.client.write_point "events",
+InfluxDB::Rails.write_api.write(
+  name: "events",
   tags:   { url: "/foo", user_id: current_user.id, location: InfluxDB::Rails.current.location },
-  values: { value: 0 }
+  fields: { value: 0 }
+)
 ```
 
 If you do that, it might be useful to add the current context to these custom
 data points which can get accessed with `InfluxDB::Rails.current.location`.
 
-See [influxdb-ruby](http://github.com/influxdata/influxdb-ruby) for a
+See [influxdb-client](https://github.com/influxdata/influxdb-client-ruby) for a
 full list of configuration options and detailed usage.
 
 ### Disabling hooks

lib/influxdb/rails/context.rb

@@ -3,7 +3,7 @@ module Rails
     class Context
       def reset
         Thread.current[:_influxdb_rails_tags] = {}
-        Thread.current[:_influxdb_rails_values] = {}
+        Thread.current[:_influxdb_rails_fields] = {}
       end
 
       def tags
@@ -14,12 +14,12 @@ def tags=(tags)
         Thread.current[:_influxdb_rails_tags] = self.tags.merge(tags)
       end
 
-      def values
-        Thread.current[:_influxdb_rails_values].to_h
+      def fields
+        Thread.current[:_influxdb_rails_fields].to_h
       end
 
-      def values=(values)
-        Thread.current[:_influxdb_rails_values] = self.values.merge(values)
+      def fields=(fields)
+        Thread.current[:_influxdb_rails_fields] = self.fields.merge(fields)
       end
     end
   end

lib/influxdb/rails/metric.rb

@@ -3,11 +3,11 @@
 module InfluxDB
   module Rails
     class Metric
-      def initialize(configuration:, timestamp:, tags: {}, values: {})
+      def initialize(configuration:, timestamp:, tags: {}, fields: {})
         @configuration = configuration
         @timestamp = timestamp
         @tags = tags
-        @values = values
+        @fields = fields
       end
 
       def write
@@ -16,11 +16,11 @@ def write
 
       private
 
-      attr_reader :configuration, :tags, :values, :timestamp
+      attr_reader :configuration, :tags, :fields, :timestamp
 
       def data
         {
-          fields: values.merge(InfluxDB::Rails.current.values),
+          fields: fields.merge(InfluxDB::Rails.current.fields),
           tags:   Tags.new(tags: tags, config: configuration).to_h,
           name:   configuration.measurement_name,
           time:   timestamp.utc,

lib/influxdb/rails/middleware/action_mailer_subscriber.rb

@@ -6,7 +6,7 @@ module Middleware
       class ActionMailerSubscriber < Subscriber # :nodoc:
         private
 
-        def values
+        def fields
           { value: 1 }
         end
 

lib/influxdb/rails/middleware/active_job_subscriber.rb

@@ -13,7 +13,7 @@ class ActiveJobSubscriber < Subscriber # :nodoc:
         }.freeze
         private_constant :JOB_STATE
 
-        def values
+        def fields
           {
             value: value,
           }

lib/influxdb/rails/middleware/active_record_subscriber.rb

@@ -7,7 +7,7 @@ module Middleware
       class ActiveRecordSubscriber < Subscriber # :nodoc:
         private
 
-        def values
+        def fields
           {
             value:        duration,
             record_count: payload[:record_count],

lib/influxdb/rails/middleware/block_instrumentation_subscriber.rb

@@ -6,10 +6,10 @@ module Middleware
       class BlockInstrumentationSubscriber < Subscriber
         private
 
-        def values
+        def fields
           {
             value: duration,
-          }.merge(payload[:values].to_h)
+          }.merge(payload[:fields].to_h)
         end
 
         def tags

lib/influxdb/rails/middleware/render_subscriber.rb

@@ -6,7 +6,7 @@ module Middleware
       class RenderSubscriber < Subscriber # :nodoc:
         private
 
-        def values
+        def fields
           {
             value:      duration,
             count:      payload[:count],

lib/influxdb/rails/middleware/request_subscriber.rb

@@ -23,7 +23,7 @@ def tags
           }
         end
 
-        def values
+        def fields
           {
             controller: duration,
             view:       (payload[:view_runtime] || 0).ceil,

lib/influxdb/rails/middleware/sql_subscriber.rb

@@ -7,7 +7,7 @@ module Middleware
       class SqlSubscriber < Subscriber # :nodoc:
         private
 
-        def values
+        def fields
           {
             value: duration,
             sql:   InfluxDB::Rails::Sql::Normalizer.new(payload[:sql]).perform,

lib/influxdb/rails/middleware/subscriber.rb

@@ -39,7 +39,7 @@ def write
 
         def metric
           InfluxDB::Rails::Metric.new(
-            values:        values,
+            fields:        fields,
             tags:          tags,
             configuration: configuration,
             timestamp:     finish
@@ -50,7 +50,7 @@ def tags
           raise NotImplementedError, "must be implemented in subclass"
         end
 
-        def values
+        def fields
           raise NotImplementedError, "must be implemented in subclass"
         end
 

lib/influxdb/rails/railtie.rb

@@ -13,7 +13,7 @@ class Railtie < ::Rails::Railtie # :nodoc:
         ActiveSupport.on_load(:action_controller) do
           before_action do
             current = InfluxDB::Rails.current
-            current.values = { request_id: request.request_id } if request.respond_to?(:request_id)
+            current.fields = { request_id: request.request_id } if request.respond_to?(:request_id)
           end
         end
 

spec/integration/influxdb_rails_sends_metrics_spec.rb

@@ -10,7 +10,7 @@
       body:  "rails,hook=block_instrumentation,location=raw,name=name,server=hostname value=1i 1514797200000000000"
     )
 
-    InfluxDB::Rails.instrument "name", values: { value: 1 }
+    InfluxDB::Rails.instrument "name", fields: { value: 1 }
 
     assert_requested(request, times: 1)
   end

spec/requests/action_controller_metrics_spec.rb

@@ -24,7 +24,7 @@
         format:      :html,
         http_method: "GET"
       ),
-      values: a_hash_including(
+      fields: a_hash_including(
         view:       be_between(1, 500),
         db:         be_between(1, 500),
         controller: be_between(1, 500)
@@ -46,8 +46,11 @@
         tags_middleware: :tags_middleware
       ),
       fields: a_hash_including(
-        additional_value: :value,
-        request_id:       :request_id
+        additional_field: :value,
+        request_id:       :request_id,
+        view:             be_between(1, 500),
+        db:               be_between(1, 500),
+        controller:       be_between(1, 500)
       )
     )
   end

spec/requests/action_mailer_deliver_metrics_spec.rb

@@ -23,7 +23,7 @@
         mailer: "MetricMailer"
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            1
       )

spec/requests/action_view_collection_metrics_spec.rb

@@ -23,7 +23,7 @@
         filename: include("spec/support/views/metrics/_item.html.erb")
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         count:            3,
         request_id:       :request_id,
         value:            be_between(1, 500)

spec/requests/action_view_partial_metrics_spec.rb

@@ -22,7 +22,7 @@
         filename: include("spec/support/views/metrics/_item.html.erb")
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            be_between(1, 500)
       )

spec/requests/action_view_template_metrics_spec.rb

@@ -22,7 +22,7 @@
         filename: include("spec/support/views/metrics/index.html.erb")
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            be_between(1, 500)
       )

spec/requests/active_job_enqueue_metrics_spec.rb

@@ -25,7 +25,7 @@
         state: "queued"
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            1
       )

spec/requests/active_record_instantiation_metrics_spec.rb

@@ -24,7 +24,7 @@
         class_name: "Metric"
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            be_between(1, 500),
         record_count:     1

spec/requests/active_record_sql_metrics_spec.rb

@@ -26,7 +26,7 @@
         operation:  "INSERT"
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            be_between(1, 500),
         sql:              "INSERT INTO \"metrics\" (\"name\", \"created_at\", \"updated_at\") VALUES (xxx)"
@@ -47,7 +47,7 @@
         operation:  "INSERT"
       ),
       fields: a_hash_including(
-        additional_value: :value,
+        additional_field: :value,
         request_id:       :request_id,
         value:            be_between(1, 500),
         sql:              "INSERT INTO \"metrics\" (\"name\", \"created_at\", \"updated_at\") VALUES (xxx)"