Skip to content

Commit b6810af

Browse files
committed
test(transform-io): add node tests
And associated fixes.
1 parent d23613d commit b6810af

File tree

24 files changed

+247
-47
lines changed

24 files changed

+247
-47
lines changed

packages/core/typescript/itk-wasm/src/bindgen/interface-json-type-to-interface-type.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const interfaceJsonTypeToInterfaceType = new Map([
1919
['OUTPUT_POINT_SET', 'PointSet'],
2020
['INPUT_POLYDATA', 'PolyData'],
2121
['OUTPUT_POLYDATA', 'PolyData'],
22-
['INPUT_TRANSFORM', 'Transform'],
23-
['OUTPUT_TRANSFORM', 'Transform'],
22+
['INPUT_TRANSFORM', 'TransformList'],
23+
['OUTPUT_TRANSFORM', 'TransformList'],
2424
['INPUT_JSON', 'JsonCompatible'],
2525
['OUTPUT_JSON', 'JsonCompatible']
2626
])

packages/core/typescript/itk-wasm/src/bindgen/python/interface-json-type-to-python-type.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const interfaceJsonTypeToPythonType = new Map([
1919
['OUTPUT_POINT_SET', 'PointSet'],
2020
['INPUT_POLYDATA', 'PolyData'],
2121
['OUTPUT_POLYDATA', 'PolyData'],
22-
['INPUT_TRANSFORM', 'Transform'],
23-
['OUTPUT_TRANSFORM', 'Transform'],
22+
['INPUT_TRANSFORM', 'TransformList'],
23+
['OUTPUT_TRANSFORM', 'TransformList'],
2424
['BOOL', 'bool'],
2525
['TEXT', 'str'],
2626
['INT', 'int'],

packages/core/typescript/itk-wasm/src/bindgen/typescript/function-module.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ function functionModule(
471471
functionContent += ` inputs.push({ type: InterfaceTypes.${interfaceType}, data: { data: value } })\n`
472472
functionContent += ' args.push(inputCountString)\n\n'
473473
} else {
474-
// Image, Mesh, PointSet, PolyData, Transform, JsonCompatible
474+
// Image, Mesh, PointSet, PolyData, TransformList, JsonCompatible
475475
functionContent +=
476476
' const inputCountString = inputs.length.toString()\n'
477477
functionContent += ` inputs.push({ type: InterfaceTypes.${interfaceType}, data: value as ${interfaceType} })\n`
@@ -511,7 +511,7 @@ function functionModule(
511511
functionContent += ` inputs.push({ type: InterfaceTypes.${interfaceType}, data: { data: options.${camel} } })\n`
512512
functionContent += ` args.push('--${parameter.name}', inputCountString)\n\n`
513513
} else {
514-
// Image, Mesh, PointSet, PolyData, Transform, JsonCompatible
514+
// Image, Mesh, PointSet, PolyData, TransformList, JsonCompatible
515515
functionContent +=
516516
' const inputCountString = inputs.length.toString()\n'
517517
functionContent += ` inputs.push({ type: InterfaceTypes.${interfaceType}, data: options.${camel} as ${interfaceType} })\n`

packages/core/typescript/itk-wasm/src/bindgen/typescript/interface-json-type-to-typescript-type.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const interfaceJsonTypeToTypeScriptType = new Map([
1919
['OUTPUT_POINT_SET', 'PointSet'],
2020
['INPUT_POLYDATA', 'PolyData'],
2121
['OUTPUT_POLYDATA', 'PolyData'],
22-
['INPUT_TRANSFORM', 'Transform'],
23-
['OUTPUT_TRANSFORM', 'Transform'],
22+
['INPUT_TRANSFORM', 'TransformList'],
23+
['OUTPUT_TRANSFORM', 'TransformList'],
2424
['BOOL', 'boolean'],
2525
['TEXT', 'string'],
2626
['INT', 'number'],

packages/core/typescript/itk-wasm/src/bindgen/typescript/types-require-import.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const typesRequireImport = [
33
'Mesh',
44
'PointSet',
55
'PolyData',
6-
'Transform',
6+
'TransformList',
77
'TextFile',
88
'BinaryFile',
99
'TextFile',

packages/core/typescript/itk-wasm/src/interface-types/index-common.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ export { default as PolyDataType } from './poly-data-type.js'
2626
export { default as TransformParameterizations } from './transform-parameterizations.js'
2727
export { default as TransformType } from './transform-type.js'
2828
export { default as Transform } from './transform.js'
29+
export type { default as TransformList } from './transform-list.js'
2930

3031
export { default as InterfaceTypes } from './interface-types.js'

packages/core/typescript/itk-wasm/src/interface-types/interface-types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const InterfaceTypes = {
77
PointSet: 'PointSet',
88
Mesh: 'Mesh',
99
PolyData: 'PolyData',
10-
Transform: 'Transform',
10+
TransformList: 'TransformList',
1111
JsonCompatible: 'JsonCompatible'
1212
} as const
1313

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import Transform from './transform.js'
2+
3+
type TransformList = Transform[]
4+
5+
export default TransformList

packages/core/typescript/itk-wasm/src/interface-types/transform-type.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import TransformParameterizations from './transform-parameterizations.js'
2+
import FloatTypes from './float-types.js'
23

34
class TransformType {
45
constructor (
6+
public readonly transformParameterization: (typeof TransformParameterizations)[keyof typeof TransformParameterizations] = TransformParameterizations.Identity,
7+
public readonly parametersValueType: typeof FloatTypes[keyof typeof FloatTypes] = FloatTypes.Float64,
58
public readonly inputDimension: number = 3,
6-
public readonly outputDimension: number = 3,
7-
public readonly transformParameterization: (typeof TransformParameterizations)[keyof typeof TransformParameterizations] = TransformParameterizations.Identity
9+
public readonly outputDimension: number = 3
810
) {}
911
}
1012

packages/core/typescript/itk-wasm/src/interface-types/transform.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import TransformType from './transform-type.js'
2+
import type TypedArray from '../typed-array.js'
23

34
class Transform {
45
transformType: TransformType
@@ -10,8 +11,8 @@ class Transform {
1011
inputSpaceName: string
1112
outputSpaceName: string
1213

13-
parameters: number[]
14-
fixedParameters: number[]
14+
parameters: TypedArray
15+
fixedParameters: TypedArray
1516

1617
constructor (transformType = new TransformType()) {
1718
this.transformType = transformType
@@ -21,8 +22,8 @@ class Transform {
2122
this.inputSpaceName = ''
2223
this.outputSpaceName = ''
2324

24-
this.parameters = new Array(0)
25-
this.fixedParameters = new Array(0)
25+
this.parameters = new Uint8Array(0)
26+
this.fixedParameters = new Uint8Array(0)
2627
}
2728
}
2829

0 commit comments

Comments
 (0)