Merge branch 'fix/network-log-oom' of https://github.com/Instabug/Instabug-React-Native into fix/network-log-oom

Author: sarahkhaledd

src/modules/NetworkLogger.ts

@@ -27,14 +27,24 @@ export const setEnabled = (isEnabled: boolean) => {
             network = await _networkDataObfuscationHandler(network);
           }
 
-          if (isContentTypeNotAllowed(network.requestContentType)) {
+          if (network.requestBodySize > InstabugConstants.MAX_NETWORK_BODY_SIZE_IN_BYTES) {
+            network.requestBody = InstabugConstants.MAX_REQUEST_BODY_SIZE_EXCEEDED_MESSAGE;
+            console.warn('IBG-RN:', InstabugConstants.MAX_REQUEST_BODY_SIZE_EXCEEDED_MESSAGE);
+          }
+
+          if (network.responseBodySize > InstabugConstants.MAX_NETWORK_BODY_SIZE_IN_BYTES) {
+            network.responseBody = InstabugConstants.MAX_RESPONSE_BODY_SIZE_EXCEEDED_MESSAGE;
+            console.warn('IBG-RN:', InstabugConstants.MAX_RESPONSE_BODY_SIZE_EXCEEDED_MESSAGE);
+          }
+
+          if (network.requestBody && isContentTypeNotAllowed(network.requestContentType)) {
             network.requestBody = `Body is omitted because content type ${network.requestContentType} isn't supported`;
             console.warn(
               `IBG-RN: The request body for the network request with URL ${network.url} has been omitted because the content type ${network.requestContentType} isn't supported.`,
             );
           }
 
-          if (isContentTypeNotAllowed(network.contentType)) {
+          if (network.responseBody && isContentTypeNotAllowed(network.contentType)) {
             network.responseBody = `Body is omitted because content type ${network.contentType} isn't supported`;
             console.warn(
               `IBG-RN: The response body for the network request with URL ${network.url} has been omitted because the content type ${network.contentType} isn't supported.`,

src/utils/InstabugConstants.ts

@@ -1,5 +1,10 @@
 enum InstabugConstants {
   GRAPHQL_HEADER = 'ibg-graphql-header',
+
+  // TODO: dyanmically get the max size from the native SDK and update the error message to reflect the dynamic size.
+  MAX_NETWORK_BODY_SIZE_IN_BYTES = 1024 * 10, // 10 KB
+  MAX_RESPONSE_BODY_SIZE_EXCEEDED_MESSAGE = 'The response body has not been logged because it exceeds the maximum size of 10 Kb',
+  MAX_REQUEST_BODY_SIZE_EXCEEDED_MESSAGE = 'The request body has not been logged because it exceeds the maximum size of 10 Kb',
 }
 
 export default InstabugConstants;

src/utils/XhrNetworkInterceptor.ts

@@ -1,4 +1,5 @@
 import InstabugConstants from './InstabugConstants';
+import { stringifyIfNotString } from './InstabugUtils';
 
 export type ProgressCallback = (totalBytesSent: number, totalBytesExpectedToSend: number) => void;
 export type NetworkDataCallback = (data: NetworkData) => void;
@@ -80,7 +81,12 @@ export default {
     };
 
     XMLHttpRequest.prototype.setRequestHeader = function (header, value) {
-      network.requestHeaders[header] = typeof value === 'string' ? value : JSON.stringify(value);
+      // According to the HTTP RFC, headers are case-insensitive, so we convert
+      // them to lower-case to make accessing headers predictable.
+      // This avoid issues like failing to get the Content-Type header for a request
+      // because the header is set as 'Content-Type' instead of 'content-type'.
+      const key = header.toLowerCase();
+      network.requestHeaders[key] = stringifyIfNotString(value);
       originalXHRSetRequestHeader.apply(this, [header, value]);
     };