feat:add feature flag change listener for android

Author: kholood-ea

examples/default/src/App.tsx

@@ -50,7 +50,7 @@ export const App: React.FC = () => {
         token: 'deb1910a7342814af4e4c9210c786f35',
         invocationEvents: [InvocationEvent.floatingButton],
         debugLogsLevel: LogLevel.verbose,
-        networkInterceptionMode: NetworkInterceptionMode.native,
+        networkInterceptionMode: NetworkInterceptionMode.javascript,
       });
 
       CrashReporting.setNDKCrashesEnabled(true);

src/modules/Instabug.ts

@@ -16,7 +16,7 @@ import type { NavigationAction, NavigationState as NavigationStateV4 } from 'rea
 import type { InstabugConfig } from '../models/InstabugConfig';
 import Report from '../models/Report';
 import { emitter, NativeEvents, NativeInstabug } from '../native/NativeInstabug';
-import { registerW3CFlagsListener } from '../utils/FeatureFlags';
+import { registerFeatureFlagsListener } from '../utils/FeatureFlags';
 import {
   AutoMaskingType,
   ColorTheme,
@@ -87,7 +87,7 @@ function reportCurrentViewForAndroid(screenName: string | null) {
 export const init = async (config: InstabugConfig) => {
   if (Platform.OS === 'android') {
     // Add android feature flags listener for android
-    registerW3CFlagsListener();
+    registerFeatureFlagsListener();
     addOnFeatureUpdatedListener(config);
   } else {
     isNativeInterceptionFeatureEnabled = await NativeNetworkLogger.isNativeInterceptionEnabled();
@@ -871,20 +871,21 @@ export const componentDidAppearListener = (event: ComponentDidAppearEvent) => {
 };
 
 /**
- * Sets listener to W3ExternalTraceID flag changes
+ * Sets listener to feature flag changes
  * @param handler A callback that gets the update value of the flag
  */
-export const _registerW3CFlagsChangeListener = (
+export const _registerFeatureFlagsChangeListener = (
   handler: (payload: {
     isW3ExternalTraceIDEnabled: boolean;
     isW3ExternalGeneratedHeaderEnabled: boolean;
     isW3CaughtHeaderEnabled: boolean;
+    networkBodyLimit: number;
   }) => void,
 ) => {
-  emitter.addListener(NativeEvents.ON_W3C_FLAGS_CHANGE, (payload) => {
+  emitter.addListener(NativeEvents.ON_FEATURE_FLAGS_CHANGE, (payload) => {
     handler(payload);
   });
-  NativeInstabug.registerW3CFlagsChangeListener();
+  NativeInstabug.registerFeatureFlagsChangeListener();
 };
 
 /**

src/native/NativeInstabug.ts

@@ -152,8 +152,8 @@ export interface InstabugNativeModule extends NativeModule {
 
   isW3CaughtHeaderEnabled(): Promise<boolean>;
 
-  // W3C Feature Flags Listener for Android
-  registerW3CFlagsChangeListener(): void;
+  // Feature Flags Listener for Android
+  registerFeatureFlagsChangeListener(): void;
 
   setOnFeaturesUpdatedListener(handler?: (params: any) => void): void; // android only
   enableAutoMasking(autoMaskingTypes: AutoMaskingType[]): void;
@@ -165,7 +165,7 @@ export const NativeInstabug = NativeModules.Instabug;
 export enum NativeEvents {
   PRESENDING_HANDLER = 'IBGpreSendingHandler',
   IBG_ON_FEATURES_UPDATED_CALLBACK = 'IBGOnFeatureUpdatedCallback',
-  ON_W3C_FLAGS_CHANGE = 'IBGOnNewW3CFlagsUpdateReceivedCallback',
+  ON_FEATURE_FLAGS_CHANGE = 'IBGOnNewFeatureFlagsUpdateReceivedCallback',
 }
 
 export const emitter = new NativeEventEmitter(NativeInstabug);

src/utils/FeatureFlags.ts

@@ -1,5 +1,5 @@
 import { NativeInstabug } from '../native/NativeInstabug';
-import { _registerW3CFlagsChangeListener } from '../modules/Instabug';
+import { _registerFeatureFlagsChangeListener } from '../modules/Instabug';
 
 export const FeatureFlags = {
   isW3ExternalTraceID: () => NativeInstabug.isW3ExternalTraceIDEnabled(),
@@ -8,12 +8,13 @@ export const FeatureFlags = {
   networkLogLimit: () => NativeInstabug.getNetworkBodyMaxSize(),
 };
 
-export const registerW3CFlagsListener = () => {
-  _registerW3CFlagsChangeListener(
+export const registerFeatureFlagsListener = () => {
+  _registerFeatureFlagsChangeListener(
     (res: {
       isW3ExternalTraceIDEnabled: boolean;
       isW3ExternalGeneratedHeaderEnabled: boolean;
       isW3CaughtHeaderEnabled: boolean;
+      networkBodyLimit: number;
     }) => {
       FeatureFlags.isW3ExternalTraceID = async () => {
         return res.isW3ExternalTraceIDEnabled;
@@ -24,6 +25,9 @@ export const registerW3CFlagsListener = () => {
       FeatureFlags.isW3CaughtHeader = async () => {
         return res.isW3CaughtHeaderEnabled;
       };
+      FeatureFlags.networkLogLimit = async () => {
+        return res.networkBodyLimit;
+      };
     },
   );
 };

test/mocks/mockInstabug.ts

@@ -72,7 +72,7 @@ const mockInstabug: InstabugNativeModule = {
   isW3ExternalTraceIDEnabled: jest.fn(),
   isW3ExternalGeneratedHeaderEnabled: jest.fn(),
   isW3CaughtHeaderEnabled: jest.fn(),
-  registerW3CFlagsChangeListener: jest.fn(),
+  registerFeatureFlagsChangeListener: jest.fn(),
   setNetworkLogBodyEnabled: jest.fn(),
   setOnFeaturesUpdatedListener: jest.fn(),
   enableAutoMasking: jest.fn(),

test/modules/Instabug.spec.ts

@@ -902,17 +902,17 @@ describe('Instabug Module', () => {
 
   it('should register W3C flag listener', async () => {
     const callback = jest.fn();
-    Instabug._registerW3CFlagsChangeListener(callback);
+    Instabug._registerFeatureFlagsChangeListener(callback);
 
-    expect(NativeInstabug.registerW3CFlagsChangeListener).toBeCalledTimes(1);
+    expect(NativeInstabug.registerFeatureFlagsChangeListener).toBeCalledTimes(1);
   });
 
   it('should invoke callback on emitting the event IBGOnNewW3CFlagsUpdateReceivedCallback', () => {
     const callback = jest.fn();
-    Instabug._registerW3CFlagsChangeListener(callback);
-    emitter.emit(NativeEvents.ON_W3C_FLAGS_CHANGE);
+    Instabug._registerFeatureFlagsChangeListener(callback);
+    emitter.emit(NativeEvents.ON_FEATURE_FLAGS_CHANGE);
 
-    expect(emitter.listenerCount(NativeEvents.ON_W3C_FLAGS_CHANGE)).toBe(1);
+    expect(emitter.listenerCount(NativeEvents.ON_FEATURE_FLAGS_CHANGE)).toBe(1);
     expect(callback).toHaveBeenCalled();
   });