Skip to content

Commit 7fa9f35

Browse files
ezhulenevtensorflower-gardener
authored andcommitted
[xla] Migrate to PjRtFuture<>::MakePromise() API
PiperOrigin-RevId: 806042342
1 parent 080c8bf commit 7fa9f35

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

third_party/xla/xla/pjrt/cpu/raw_buffer.cc

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,20 +77,19 @@ void CpuTrackedDeviceEventPromise::SetReady() {
7777
}
7878

7979
PjRtFuture<> CpuTrackedDeviceEvent::GetReadyFuture() {
80-
PjRtFuture<>::Promise promise = PjRtFuture<>::CreatePromise();
81-
event_.AndThen([promise, event = event_]() mutable {
80+
auto [promise, future] = PjRtFuture<>::MakePromise();
81+
event_.AndThen([promise = std::move(promise), event = event_]() mutable {
8282
if (auto* error = event.GetErrorIfPresent()) {
8383
promise.Set(*error);
8484
} else {
8585
promise.Set();
8686
}
8787
});
8888

89-
return PjRtFuture<>(
90-
promise,
89+
return PjRtFutureHelpers::WithProfiling(
90+
std::move(future),
9191
/*on_block_start=*/
92-
[ready_event = FormRef(promise.async_value()),
93-
callee_method = callee_method_, callee_type = callee_type_]() {
92+
[callee_method = callee_method_, callee_type = callee_type_]() {
9493
tsl::profiler::TraceMeProducer traceme(
9594
[&] { return absl::StrCat(callee_type, "::", callee_method); });
9695
return PjRtFutureHelpers::ProfilingKeys({traceme.GetContextId()});

0 commit comments

Comments
 (0)