address reviewer's comments

Author: Vahid Tavanashad

dpctl/tensor/_elementwise_funcs.py

@@ -1429,6 +1429,12 @@
         First input array, expected to have a real-valued data type.
     x2 (usm_ndarray):
         Second input array, also expected to have a real-valued data type.
+    out ({None, usm_ndarray}, optional):
+        Output array to populate.
+        Array have the correct shape and the expected data type.
+    order ("C","F","A","K", optional):
+        Memory layout of the newly output array, if parameter `out` is `None`.
+        Default: "K".
 Returns:
     usm_ndarray:
         an array containing the element-wise remainders. The data type of

dpctl/tensor/libtensor/include/kernels/elementwise_functions/maximum.hpp

@@ -71,14 +71,10 @@ template <typename argT1, typename argT2, typename resT> struct MaximumFunctor
             realT imag1 = std::imag(in1);
             realT imag2 = std::imag(in2);
 
-            if (std::isnan(real1) || std::isnan(imag1))
-                return in1;
-            else if (std::isnan(real2) || std::isnan(imag2))
-                return in2;
-            else if (real1 == real2)
-                return imag1 > imag2 ? in1 : in2;
-            else
-                return real1 > real2 ? in1 : in2;
+            bool gt = (real1 == real2) ? (imag1 > imag2)
+                                       : (real1 > real2 && !std::isnan(imag1) &&
+                                          !std::isnan(imag2));
+            return (std::isnan(real1) || std::isnan(imag1) || gt) ? in1 : in2;
         }
         else {
             return (in1 != in1 || in1 > in2) ? in1 : in2;

dpctl/tensor/libtensor/include/kernels/elementwise_functions/minimum.hpp

@@ -71,14 +71,10 @@ template <typename argT1, typename argT2, typename resT> struct MinimumFunctor
             realT imag1 = std::imag(in1);
             realT imag2 = std::imag(in2);
 
-            if (std::isnan(real1) || std::isnan(imag1))
-                return in1;
-            else if (std::isnan(real2) || std::isnan(imag2))
-                return in2;
-            else if (real1 == real2)
-                return imag1 < imag2 ? in1 : in2;
-            else
-                return real1 < real2 ? in1 : in2;
+            bool gt = (real1 == real2) ? (imag1 < imag2)
+                                       : (real1 < real2 && !std::isnan(imag1) &&
+                                          !std::isnan(imag2));
+            return (std::isnan(real1) || std::isnan(imag1) || gt) ? in1 : in2;
         }
         else {
             return (in1 != in1 || in1 < in2) ? in1 : in2;