Skip to content

PHP methods should not contain too much logic #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JBlond opened this issue Jan 9, 2019 · 2 comments
Closed

PHP methods should not contain too much logic #3

JBlond opened this issue Jan 9, 2019 · 2 comments

Comments

@JBlond
Copy link
Owner

JBlond commented Jan 9, 2019

100 lines for Diff_Renderer_Html_SideBySide::render() in lib/Diff/Renderer/Html/SideBySide.php, line 56
80 lines for Diff_Renderer_Html_Inline::render() in lib/Diff/Renderer/Html/Inline.php, line 56
54 lines for Diff_Renderer_Text_Context::render() in lib/Diff/Renderer/Text/Context.php, line 65
53 lines for Diff_Renderer_Html_Array::render() in lib/Diff/Renderer/Html/Array.php, line 115
@Creris
Copy link

Creris commented Jan 10, 2019

Hey,

I would like to do try to tackle this tomorrow morning.

@JBlond
Copy link
Owner Author

JBlond commented Jan 11, 2019

Thanks a lot for your PR #4

@JBlond JBlond closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants