Skip to content

min and max should be replaced by minimum and maximum #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
getzdan opened this issue Jul 24, 2014 · 2 comments
Closed

min and max should be replaced by minimum and maximum #49

getzdan opened this issue Jul 24, 2014 · 2 comments

Comments

@getzdan
Copy link

getzdan commented Jul 24, 2014

in conversions.jl, colormaps.jl and utilities.jl:
min and max are used instead of minimum and maximum.
a search and replace should resolve this quickly.
@timholy
Copy link
Contributor

timholy commented Jul 24, 2014

I fixed one of these earlier today. I'm in the middle of a much bigger change right now (implementing #42), so if you want it soon maybe you could do it yourself and submit a pull request?

@jiahao
Copy link
Contributor

jiahao commented Aug 27, 2014

Looks like this has been fixed

@jiahao jiahao closed this as completed Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiahao @timholy @getzdan