Partially debug null type issue

pchintalapudi · pchintalapudi · commit 43e9ee3b2b57 · 2022-03-09T20:22:03.000-05:00
diff --git a/src/aotcompile.cpp b/src/aotcompile.cpp
@@ -34,6 +34,7 @@
 #include <llvm/Transforms/Utils/SimplifyCFGOptions.h>
 #include <llvm/Passes/PassBuilder.h>
 #include <llvm/Passes/PassPlugin.h>
+#include <llvm/Passes/StandardInstrumentations.h>
 #if defined(USE_POLLY)
 #include <polly/RegisterPasses.h>
 #include <polly/LinkAllPasses.h>
@@ -1216,7 +1217,10 @@ void addPipeline(ModulePassManager &MPM, int opt_level, bool lower_intrinsics, b
 void optimizeModule(Module &M, TargetMachine *TM, int opt_level, bool lower_intrinsics, bool dump_native)
 {
     // llvm::PassBuilder pb(targetMachine->LLVM, llvm::PipelineTuningOptions(), llvm::None, &passInstrumentationCallbacks);
-    PassBuilder PB;
+    PassInstrumentationCallbacks PIC;
+    StandardInstrumentations SI(false);
+    SI.registerCallbacks(PIC);
+    PassBuilder PB(TM, PipelineTuningOptions(), None, &PIC);
     // Create the analysis managers.
     LoopAnalysisManager LAM;
     PB.registerLoopAnalyses(LAM);
diff --git a/src/llvm-alloc-opt.cpp b/src/llvm-alloc-opt.cpp
@@ -20,6 +20,7 @@
 #include <llvm/IR/Module.h>
 #include <llvm/IR/Operator.h>
 #include <llvm/IR/IRBuilder.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Pass.h>
 #include <llvm/Support/Debug.h>
 #include <llvm/Transforms/Utils/PromoteMemToReg.h>
@@ -1148,7 +1149,9 @@ bool AllocOpt::runOnFunction(Function &F, function_ref<DominatorTree&()> GetDT)
     Optimizer optimizer(F, *this, std::move(GetDT));
     optimizer.initialize();
     optimizer.optimizeAll();
-    return optimizer.finalize();
+    auto changed = optimizer.finalize();
+    assert(!verifyFunction(F));
+    return changed;
 }
 
 struct AllocOptLegacy : public FunctionPass {
diff --git a/src/llvm-cpufeatures.cpp b/src/llvm-cpufeatures.cpp
@@ -21,6 +21,7 @@
 #include <llvm/IR/Instructions.h>
 #include <llvm/IR/PassManager.h>
 #include <llvm/IR/LegacyPassManager.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Target/TargetMachine.h>
 #include <llvm/Support/Debug.h>
 
@@ -104,6 +105,7 @@ bool lowerCPUFeatures(Module &M)
         for (auto I: Materialized) {
             I->eraseFromParent();
         }
+        assert(!verifyModule(M));
         return true;
     } else {
         return false;
diff --git a/src/llvm-demote-float16.cpp b/src/llvm-demote-float16.cpp
@@ -24,6 +24,7 @@
 #include <llvm/IR/LegacyPassManager.h>
 #include <llvm/IR/PassManager.h>
 #include <llvm/IR/Module.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Support/Debug.h>
 
 using namespace llvm;
@@ -121,6 +122,7 @@ static bool demoteFloat16(Function &F)
     if (erase.size() > 0) {
         for (auto V : erase)
             V->eraseFromParent();
+        assert(!verifyFunction(F));
         return true;
     }
     else
diff --git a/src/llvm-final-gc-lowering.cpp b/src/llvm-final-gc-lowering.cpp
@@ -8,6 +8,7 @@
 #include <llvm/IR/IntrinsicInst.h>
 #include <llvm/IR/Module.h>
 #include <llvm/IR/IRBuilder.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Pass.h>
 #include <llvm/Support/Debug.h>
 #include <llvm/Transforms/Utils/ModuleUtils.h>
@@ -211,6 +212,7 @@ bool FinalLowerGC::doInitialization(Module &M) {
     }
     if (j != 0)
         appendToCompilerUsed(M, ArrayRef<GlobalValue*>(functionList, j));
+    assert(!verifyModule(M));
     return true;
 }
 
@@ -244,6 +246,7 @@ bool FinalLowerGC::doFinalization(Module &M)
     used = new GlobalVariable(M, ATy, false, GlobalValue::AppendingLinkage,
                                     ConstantArray::get(ATy, init), "llvm.compiler.used");
     used->setSection("llvm.metadata");
+    assert(!verifyModule(M));
     return true;
 }
 
@@ -320,6 +323,8 @@ bool FinalLowerGC::runOnFunction(Function &F)
         }
     }
 
+    assert(!verifyFunction(F));
+
     return true;
 }
 
diff --git a/src/llvm-julia-licm.cpp b/src/llvm-julia-licm.cpp
@@ -8,6 +8,7 @@
 #include "llvm/Analysis/LoopIterator.h"
 #include <llvm/IR/Dominators.h>
 #include <llvm/IR/LegacyPassManager.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Transforms/Utils/LoopUtils.h>
 #include <llvm/Analysis/ValueTracking.h>
 
@@ -174,6 +175,7 @@ struct JuliaLICM : public JuliaPassContext {
                 }
             }
         }
+        assert(!verifyFunction(*L->getBlocks()[0]->getParent()));
         return changed;
     }
 };
diff --git a/src/llvm-late-gc-lowering.cpp b/src/llvm-late-gc-lowering.cpp
@@ -2699,6 +2699,7 @@ bool LateLowerGCFrame::runOnFunction(Function &F, bool *CFGModified) {
     std::map<Value *, std::pair<int, int>> CallFrames; // = OptimizeCallFrames(S, Ordering);
     PlaceRootsAndUpdateCalls(Colors, S, CallFrames);
     CleanupIR(F, &S, CFGModified);
+    assert(!verifyFunction(F));
     return true;
 }
 
diff --git a/src/llvm-lower-handlers.cpp b/src/llvm-lower-handlers.cpp
@@ -16,6 +16,7 @@
 #include <llvm/IR/Module.h>
 #include <llvm/IR/Value.h>
 #include <llvm/IR/LegacyPassManager.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Pass.h>
 #include <llvm/Support/Debug.h>
 #include <llvm/Transforms/Utils/BasicBlockUtils.h>
@@ -215,6 +216,7 @@ static bool lowerExcHandlers(Function &F) {
             LifetimeEnd->insertAfter(it.first);
         }
     }
+    assert(!verifyFunction(F));
     return true;
 }
 
diff --git a/src/llvm-muladd.cpp b/src/llvm-muladd.cpp
@@ -17,6 +17,7 @@
 #include <llvm/IR/Module.h>
 #include <llvm/IR/Operator.h>
 #include <llvm/IR/IRBuilder.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Pass.h>
 #include <llvm/Support/Debug.h>
 
@@ -80,6 +81,7 @@ static bool combineMulAdd(Function &F)
             }
         }
     }
+    assert(!verifyFunction(F));
     return true;
 }
 
diff --git a/src/llvm-multiversioning.cpp b/src/llvm-multiversioning.cpp
@@ -24,6 +24,7 @@
 #include <llvm/IR/LegacyPassManager.h>
 #include <llvm/IR/IRBuilder.h>
 #include <llvm/IR/DebugInfoMetadata.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Transforms/Utils/Cloning.h>
 
 #include "julia.h"
@@ -1105,6 +1106,7 @@ static bool runMultiVersioning(Module &M, function_ref<LoopInfo&(Function&)> Get
     // and collected all the shared/target-specific relocations.
     clone.emit_metadata();
 
+    assert(!verifyModule(M));
     return true;
 }
 
diff --git a/src/llvm-propagate-addrspaces.cpp b/src/llvm-propagate-addrspaces.cpp
@@ -295,6 +295,7 @@ bool propagateJuliaAddrspaces(Function &F) {
     visitor.ToDelete.clear();
     visitor.LiftingMap.clear();
     visitor.Visited.clear();
+    assert(!verifyFunction(F));
     return true;
 }
 
diff --git a/src/llvm-ptls.cpp b/src/llvm-ptls.cpp
@@ -20,6 +20,7 @@
 #include <llvm/IR/Constants.h>
 #include <llvm/IR/LLVMContext.h>
 #include <llvm/IR/MDBuilder.h>
+#include <llvm/IR/Verifier.h>
 
 #include <llvm/IR/InlineAsm.h>
 #include <llvm/Transforms/Utils/BasicBlockUtils.h>
@@ -281,6 +282,7 @@ bool LowerPTLS::runOnModule(Module &_M, bool *CFGModified)
     }
     assert(pgcstack_getter->use_empty());
     pgcstack_getter->eraseFromParent();
+    assert(!verifyModule(_M));
     return true;
 }
 
diff --git a/src/llvm-remove-addrspaces.cpp b/src/llvm-remove-addrspaces.cpp
@@ -8,6 +8,7 @@
 #include <llvm/IR/Instructions.h>
 #include <llvm/IR/InstIterator.h>
 #include <llvm/IR/LegacyPassManager.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Support/Debug.h>
 #include <llvm/Transforms/Utils/Cloning.h>
 #include <llvm/Transforms/Utils/ValueMapper.h>
@@ -453,6 +454,7 @@ bool removeAddrspaces(Module &M, AddrspaceRemapFunction ASRemapper)
         }
     }
 
+    assert(!verifyModule(M));
     return true;
 }
 
diff --git a/src/llvm-remove-ni.cpp b/src/llvm-remove-ni.cpp
@@ -7,6 +7,7 @@
 #include <llvm/IR/Module.h>
 #include <llvm/IR/PassManager.h>
 #include <llvm/IR/LegacyPassManager.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Support/Debug.h>
 
 #include "julia.h"
@@ -32,6 +33,7 @@ static bool removeNI(Module &M)
     }
     dlstr.erase(nistart, niend - nistart);
     M.setDataLayout(dlstr);
+    assert(!verifyModule(M));
     return true;
 }
 }
diff --git a/src/llvm-simdloop.cpp b/src/llvm-simdloop.cpp
@@ -25,6 +25,7 @@
 #include <llvm/IR/Instructions.h>
 #include <llvm/IR/LLVMContext.h>
 #include <llvm/IR/Metadata.h>
+#include <llvm/IR/Verifier.h>
 #include <llvm/Support/Debug.h>
 
 #include "julia_assert.h"
@@ -205,6 +206,7 @@ static bool markLoopInfo(Module &M, Function *marker, function_ref<LoopInfo &(Fu
         I->deleteValue();
     marker->eraseFromParent();
 
+    assert(!verifyModule(M));
     return Changed;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`#include <llvm/IR/IntrinsicInst.h>`
`9`	`9`	`#include <llvm/IR/Module.h>`
`10`	`10`	`#include <llvm/IR/IRBuilder.h>`
	`11`	`+#include <llvm/IR/Verifier.h>`
`11`	`12`	`#include <llvm/Pass.h>`
`12`	`13`	`#include <llvm/Support/Debug.h>`
`13`	`14`	`#include <llvm/Transforms/Utils/ModuleUtils.h>`
`@@ -211,6 +212,7 @@ bool FinalLowerGC::doInitialization(Module &M) {`
`211`	`212`	`}`
`212`	`213`	`if (j != 0)`
`213`	`214`	`appendToCompilerUsed(M, ArrayRef<GlobalValue*>(functionList, j));`
	`215`	`+ assert(!verifyModule(M));`
`214`	`216`	`return true;`
`215`	`217`	`}`
`216`	`218`
`@@ -244,6 +246,7 @@ bool FinalLowerGC::doFinalization(Module &M)`
`244`	`246`	`used = new GlobalVariable(M, ATy, false, GlobalValue::AppendingLinkage,`
`245`	`247`	`ConstantArray::get(ATy, init), "llvm.compiler.used");`
`246`	`248`	`used->setSection("llvm.metadata");`
	`249`	`+ assert(!verifyModule(M));`
`247`	`250`	`return true;`
`248`	`251`	`}`
`249`	`252`
`@@ -320,6 +323,8 @@ bool FinalLowerGC::runOnFunction(Function &F)`
`320`	`323`	`}`
`321`	`324`	`}`
`322`	`325`
	`326`	`+ assert(!verifyFunction(F));`
	`327`	`+`
`323`	`328`	`return true;`
`324`	`329`	`}`
`325`	`330`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`#include "llvm/Analysis/LoopIterator.h"`
`9`	`9`	`#include <llvm/IR/Dominators.h>`
`10`	`10`	`#include <llvm/IR/LegacyPassManager.h>`
	`11`	`+#include <llvm/IR/Verifier.h>`
`11`	`12`	`#include <llvm/Transforms/Utils/LoopUtils.h>`
`12`	`13`	`#include <llvm/Analysis/ValueTracking.h>`
`13`	`14`
`@@ -174,6 +175,7 @@ struct JuliaLICM : public JuliaPassContext {`
`174`	`175`	`}`
`175`	`176`	`}`
`176`	`177`	`}`
	`178`	`+ assert(!verifyFunction(*L->getBlocks()[0]->getParent()));`
`177`	`179`	`return changed;`
`178`	`180`	`}`
`179`	`181`	`};`
Original file line number	Diff line number	Diff line change
`@@ -2699,6 +2699,7 @@ bool LateLowerGCFrame::runOnFunction(Function &F, bool *CFGModified) {`
`2699`	`2699`	`std::map<Value *, std::pair<int, int>> CallFrames; // = OptimizeCallFrames(S, Ordering);`
`2700`	`2700`	`PlaceRootsAndUpdateCalls(Colors, S, CallFrames);`
`2701`	`2701`	`CleanupIR(F, &S, CFGModified);`
	`2702`	`+ assert(!verifyFunction(F));`
`2702`	`2703`	`return true;`
`2703`	`2704`	`}`
`2704`	`2705`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`#include <llvm/IR/Module.h>`
`17`	`17`	`#include <llvm/IR/Value.h>`
`18`	`18`	`#include <llvm/IR/LegacyPassManager.h>`
	`19`	`+#include <llvm/IR/Verifier.h>`
`19`	`20`	`#include <llvm/Pass.h>`
`20`	`21`	`#include <llvm/Support/Debug.h>`
`21`	`22`	`#include <llvm/Transforms/Utils/BasicBlockUtils.h>`
`@@ -215,6 +216,7 @@ static bool lowerExcHandlers(Function &F) {`
`215`	`216`	`LifetimeEnd->insertAfter(it.first);`
`216`	`217`	`}`
`217`	`218`	`}`
	`219`	`+ assert(!verifyFunction(F));`
`218`	`220`	`return true;`
`219`	`221`	`}`
`220`	`222`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`#include <llvm/IR/Module.h>`
`18`	`18`	`#include <llvm/IR/Operator.h>`
`19`	`19`	`#include <llvm/IR/IRBuilder.h>`
	`20`	`+#include <llvm/IR/Verifier.h>`
`20`	`21`	`#include <llvm/Pass.h>`
`21`	`22`	`#include <llvm/Support/Debug.h>`
`22`	`23`
`@@ -80,6 +81,7 @@ static bool combineMulAdd(Function &F)`
`80`	`81`	`}`
`81`	`82`	`}`
`82`	`83`	`}`
	`84`	`+ assert(!verifyFunction(F));`
`83`	`85`	`return true;`
`84`	`86`	`}`
`85`	`87`
Original file line number	Diff line number	Diff line change
`@@ -295,6 +295,7 @@ bool propagateJuliaAddrspaces(Function &F) {`
`295`	`295`	`visitor.ToDelete.clear();`
`296`	`296`	`visitor.LiftingMap.clear();`
`297`	`297`	`visitor.Visited.clear();`
	`298`	`+ assert(!verifyFunction(F));`
`298`	`299`	`return true;`
`299`	`300`	`}`
`300`	`301`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`#include <llvm/IR/Constants.h>`
`21`	`21`	`#include <llvm/IR/LLVMContext.h>`
`22`	`22`	`#include <llvm/IR/MDBuilder.h>`
	`23`	`+#include <llvm/IR/Verifier.h>`
`23`	`24`
`24`	`25`	`#include <llvm/IR/InlineAsm.h>`
`25`	`26`	`#include <llvm/Transforms/Utils/BasicBlockUtils.h>`
`@@ -281,6 +282,7 @@ bool LowerPTLS::runOnModule(Module &_M, bool *CFGModified)`
`281`	`282`	`}`
`282`	`283`	`assert(pgcstack_getter->use_empty());`
`283`	`284`	`pgcstack_getter->eraseFromParent();`
	`285`	`+ assert(!verifyModule(_M));`
`284`	`286`	`return true;`
`285`	`287`	`}`
`286`	`288`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`#include <llvm/IR/Instructions.h>`
`9`	`9`	`#include <llvm/IR/InstIterator.h>`
`10`	`10`	`#include <llvm/IR/LegacyPassManager.h>`
	`11`	`+#include <llvm/IR/Verifier.h>`
`11`	`12`	`#include <llvm/Support/Debug.h>`
`12`	`13`	`#include <llvm/Transforms/Utils/Cloning.h>`
`13`	`14`	`#include <llvm/Transforms/Utils/ValueMapper.h>`
`@@ -453,6 +454,7 @@ bool removeAddrspaces(Module &M, AddrspaceRemapFunction ASRemapper)`
`453`	`454`	`}`
`454`	`455`	`}`
`455`	`456`
	`457`	`+ assert(!verifyModule(M));`
`456`	`458`	`return true;`
`457`	`459`	`}`
`458`	`460`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`#include <llvm/IR/Module.h>`
`8`	`8`	`#include <llvm/IR/PassManager.h>`
`9`	`9`	`#include <llvm/IR/LegacyPassManager.h>`
	`10`	`+#include <llvm/IR/Verifier.h>`
`10`	`11`	`#include <llvm/Support/Debug.h>`
`11`	`12`
`12`	`13`	`#include "julia.h"`
`@@ -32,6 +33,7 @@ static bool removeNI(Module &M)`
`32`	`33`	`}`
`33`	`34`	`dlstr.erase(nistart, niend - nistart);`
`34`	`35`	`M.setDataLayout(dlstr);`
	`36`	`+ assert(!verifyModule(M));`
`35`	`37`	`return true;`
`36`	`38`	`}`
`37`	`39`	`}`