libgit2: fix for broken SSH host callback

Author: StefanKarpinski

deps/Versions.make

@@ -33,7 +33,7 @@ CURL_JLL_NAME := LibCURL
 LAPACK_VER := 3.9.0
 
 # LibGit2
-LIBGIT2_JLL_VER := 1.2.1+0
+LIBGIT2_JLL_VER := 1.2.2+0
 LIBGIT2_JLL_NAME := LibGit2
 
 # LibSSH2

deps/checksums/LibGit2.v1.2.2+0.x86_64-apple-darwin.tar.gz/md5

@@ -0,0 +1 @@
+693080c66702c9ff106b0935f01d1f96

deps/checksums/LibGit2.v1.2.2+0.x86_64-apple-darwin.tar.gz/sha512

@@ -0,0 +1 @@
+f21d5846b443188a0c604255dce77603ea861db8d4c6fc55cebd5db6da07e94ae40f0a165221c95e13db9df8777fddb05f55c865f554f45e56cd442332a95336

deps/patches/libgit2-hostkey.patch

@@ -18,7 +18,7 @@ index e8cd2d180..54293cd31 100644
 
  /**
 diff --git a/src/transports/ssh.c b/src/transports/ssh.c
-index f4ed05bb1..049697796 100644
+index f4ed05bb1..ec6366a5f 100644
 --- a/src/transports/ssh.c
 +++ b/src/transports/ssh.c
 @@ -523,6 +523,7 @@ static int _git_ssh_setup_conn(
@@ -47,7 +47,7 @@ index f4ed05bb1..049697796 100644
  		cert_ptr = &cert;
 
 -		error = t->owner->certificate_check_cb((git_cert *) cert_ptr, 0, urldata.host, t->owner->message_cb_payload);
-+		if (git_net_url_is_default_port(&urldata)) {
++		if (atoi(urldata.port) == SSH_DEFAULT_PORT) {
 +			host_and_port = urldata.host;
 +		} else {
 +			size_t n = strlen(urldata.host) + strlen(urldata.port) + 2;

stdlib/LibGit2/src/callbacks.jl

@@ -440,14 +440,15 @@ end
 function ssh_knownhost_check(
     files :: AbstractVector{<:AbstractString},
     host  :: AbstractString,
-    key   :: String,
+    key   :: Vector{UInt8},
 )
     if (m = match(r"^(.+):(\d+)$", host)) !== nothing
         host = m.captures[1]
         port = parse(Int, m.captures[2])
     else
         port = 22 # default SSH port
     end
+    len = length(key)
     mask = Consts.LIBSSH2_KNOWNHOST_TYPE_PLAIN |
            Consts.LIBSSH2_KNOWNHOST_KEYENC_RAW
     session = @ccall "libssh2".libssh2_session_init_ex(
@@ -471,13 +472,12 @@ function ssh_knownhost_check(
             @ccall "libssh2".libssh2_knownhost_free(hosts::Ptr{Cvoid})::Cvoid
             continue
         end
-        size = ncodeunits(key)
         check = @ccall "libssh2".libssh2_knownhost_checkp(
             hosts  :: Ptr{Cvoid},
             host   :: Cstring,
             port   :: Cint,
             key    :: Ptr{UInt8},
-            size   :: Csize_t,
+            len    :: Csize_t,
             mask   :: Cint,
             C_NULL :: Ptr{Ptr{KnownHost}},
         ) :: Cint