Skip to content

Commit c7fadec

Browse files
committed
Remove obsolete ambiguity resolutions
1 parent 138aeb4 commit c7fadec

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

stdlib/LinearAlgebra/src/adjtrans.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,6 @@ function *(u::TransposeAbsVec, v::AbstractVector)
251251
end
252252
# vector * Adjoint/Transpose-vector
253253
*(u::AbstractVector, v::AdjOrTransAbsVec) = broadcast(*, u, v)
254-
# Adjoint/Transpose-vector * Adjoint/Transpose-vector
255-
# (necessary for disambiguation with fallback methods in linalg/matmul)
256-
*(u::AdjointAbsVec, v::AdjointAbsVec) = throw(MethodError(*, (u, v)))
257-
*(u::TransposeAbsVec, v::TransposeAbsVec) = throw(MethodError(*, (u, v)))
258254

259255
# AdjOrTransAbsVec{<:Any,<:AdjOrTransAbsVec} is a lazy conj vectors
260256
# We need to expand the combinations to avoid ambiguities

stdlib/LinearAlgebra/src/qr.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,6 @@ function *(A::StridedMatrix, adjB::Adjoint{<:Any,<:AbstractQ})
725725
throw(DimensionMismatch("matrix A has dimensions $(size(A)) but matrix B has dimensions $(size(B))"))
726726
end
727727
end
728-
*(u::AdjointAbsVec, A::Adjoint{<:Any,<:AbstractQ}) = adjoint(A.parent * u.parent)
729728

730729

731730
### AcQ/AcQc

stdlib/LinearAlgebra/src/triangular.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2020,11 +2020,6 @@ function *(A::AbstractMatrix, transB::Transpose{<:Any,<:AbstractTriangular})
20202020
copyto!(AA, A)
20212021
rmul!(AA, transpose(convert(AbstractArray{TAB}, B)))
20222022
end
2023-
# ambiguity resolution with definitions in linalg/rowvector.jl
2024-
*(v::AdjointAbsVec, A::AbstractTriangular) = adjoint(adjoint(A) * v.parent)
2025-
*(v::TransposeAbsVec, A::AbstractTriangular) = transpose(transpose(A) * v.parent)
2026-
*(v::AdjointAbsVec, A::Adjoint{<:Any,<:AbstractTriangular}) = adjoint(A.parent * v.parent)
2027-
*(v::TransposeAbsVec, A::Transpose{<:Any,<:AbstractTriangular}) = transpose(A.parent * v.parent)
20282023

20292024

20302025
# If these are not defined, they will fallback to the versions in matmul.jl

0 commit comments

Comments
 (0)