Skip to content

Commit c842e86

Browse files
committed
Merge pull request #13509 from JuliaLang/tk/wingit
Fix Windows Git path issues
2 parents 652184d + c18d271 commit c842e86

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

LICENSE.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,9 @@ Julia's build process uses the following external tools:
8383
Julia bundles the following external programs and libraries on some platforms:
8484

8585
- [7-Zip](http://www.7-zip.org/license.txt)
86-
- [BUSYBOX](https://github.com/rmyorston/busybox-w32/blob/master/LICENSE)
8786
- [GIT](http://git-scm.com/about/free-and-open-source)
8887
- [ZLIB](http://zlib.net/zlib_license.html)
8988
- [LIBEXPAT](http://expat.cvs.sourceforge.net/viewvc/expat/expat/README)
9089
- [OPENSSL](https://github.com/openssl/openssl/blob/master/LICENSE)
9190

92-
On some platforms, distributions of Julia contain SSL certificate authority certificates, released under the [Mozilla Public License](https://en.wikipedia.org/wiki/Mozilla_Public_License).
91+
On some platforms, distributions of Julia contain SSL certificate authority certificates, released under the [Mozilla Public License](https://en.wikipedia.org/wiki/Mozilla_Public_License).

Makefile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,8 @@ ifeq ($(OS), WINNT)
465465
cp 7z.exe 7z.dll libexpat-1.dll zlib1.dll libgfortran-3.dll libquadmath-0.dll libstdc++-6.dll libgcc_s_s*-1.dll libssp-0.dll $(bindir) && \
466466
mkdir $(DESTDIR)$(prefix)/Git && \
467467
7z x PortableGit.7z -o"$(DESTDIR)$(prefix)/Git" && \
468-
echo "[core] eol = lf" >> "$(DESTDIR)$(prefix)/Git/etc/gitconfig" && \
469-
sed -i "s/\bautocrlf = true$$/autocrlf = input/" "$(DESTDIR)$(prefix)/Git/etc/gitconfig" && \
470-
cp busybox.exe $(DESTDIR)$(prefix)/Git/bin/echo.exe && \
471-
cp busybox.exe $(DESTDIR)$(prefix)/Git/bin/printf.exe )
468+
echo "[core] eol = lf" >> "$(DESTDIR)$(prefix)"/Git/mingw*/etc/gitconfig && \
469+
sed -i "s/\bautocrlf = true$$/autocrlf = input/" "$(DESTDIR)$(prefix)"/Git/mingw*/etc/gitconfig )
472470
cd $(DESTDIR)$(bindir) && rm -f llvm* llc.exe lli.exe opt.exe LTO.dll bugpoint.exe macho-dump.exe
473471

474472
# create file listing for uninstall. note: must have Windows path separators and line endings.
@@ -612,9 +610,7 @@ endif
612610
cd $(JULIAHOME)/dist-extras && \
613611
$(JLDOWNLOAD) http://downloads.sourceforge.net/sevenzip/7z920_extra.7z && \
614612
$(JLDOWNLOAD) https://unsis.googlecode.com/files/nsis-2.46.5-Unicode-setup.exe && \
615-
$(JLDOWNLOAD) busybox.exe http://frippery.org/files/busybox/busybox-w32-FRP-1-g9eb16cb.exe && \
616613
chmod a+x 7z.exe && \
617614
chmod a+x 7z.dll && \
618615
$(call spawn,./7z.exe) x -y -onsis nsis-2.46.5-Unicode-setup.exe && \
619-
chmod a+x ./nsis/makensis.exe && \
620-
chmod a+x busybox.exe
616+
chmod a+x ./nsis/makensis.exe

contrib/windows/juliarc.jl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
# This file is a part of Julia. License is MIT: http://julialang.org/license
22

3-
let user_data_dir
4-
ENV["PATH"] = JULIA_HOME*";"*joinpath(JULIA_HOME,"..","Git","bin")*";"*ENV["PATH"]
5-
#haskey(ENV,"JULIA_EDITOR") || (ENV["JULIA_EDITOR"] = "start") #start is not a program, so this doesn't work
6-
end
3+
ENV["PATH"] = JULIA_HOME*";"*joinpath(JULIA_HOME,"..","Git","bin")*";"*
4+
joinpath(JULIA_HOME,"..","Git","usr","bin")*";"*ENV["PATH"]

contrib/windows/msys_build.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ if ! [ -e julia-installer.exe ]; then
106106
echo "Extracting $f"
107107
$SEVENZIP x -y $f >> get-deps.log
108108
fi
109-
for i in bin/*.dll Git/bin/msys-1.0.dll Git/bin/msys-perl5_8.dll Git/bin/*.exe; do
109+
for i in bin/*.dll Git/usr/bin/*.dll Git/usr/bin/*.exe; do
110110
$SEVENZIP e -y julia-installer.exe "\$_OUTDIR/$i" \
111111
-ousr\\`dirname $i | sed -e 's|/julia||' -e 's|/|\\\\|g'` >> get-deps.log
112112
done
@@ -179,8 +179,6 @@ if [ -z "`which make 2>/dev/null`" ]; then
179179
fi
180180
$SEVENZIP x -y `basename $f.lzma` >> get-deps.log
181181
tar -xf `basename $f`
182-
# msysgit has an ancient version of touch that fails with `touch -c nonexistent`
183-
cp usr/Git/bin/echo.exe bin/touch.exe
184182
export PATH=$PWD/bin:$PATH
185183
fi
186184

0 commit comments

Comments
 (0)