delay loading of extensions as much as possible (#48674)

Author: KristofferC

base/loading.jl

@@ -1080,7 +1080,6 @@ function register_restored_modules(sv::SimpleVector, pkg::PkgId, path::String)
 end
 
 function run_package_callbacks(modkey::PkgId)
-    run_extension_callbacks(modkey)
     assert_havelock(require_lock)
     unlock(require_lock)
     try
@@ -1204,53 +1203,57 @@ function run_extension_callbacks(extid::ExtensionId)
     return succeeded
 end
 
-function run_extension_callbacks(pkgid::PkgId)
+function run_extension_callbacks()
     assert_havelock(require_lock)
-    # take ownership of extids that depend on this pkgid
-    extids = pop!(EXT_DORMITORY, pkgid, nothing)
-    extids === nothing && return
-    for extid in extids
-        if extid.ntriggers > 0
-            # It is possible that pkgid was loaded in an environment
-            # below the one of the parent. This will cause a load failure when the
-            # pkg ext tries to load the triggers. Therefore, check this first
-            # before loading the pkg ext.
-            pkgenv = Base.identify_package_env(extid.id, pkgid.name)
-            ext_not_allowed_load = false
-            if pkgenv === nothing
-                ext_not_allowed_load = true
-            else
-                pkg, env = pkgenv
-                path = Base.locate_package(pkg, env)
-                if path === nothing
+    loaded_triggers = collect(intersect(keys(Base.loaded_modules), keys(Base.EXT_DORMITORY)))
+    sort!(loaded_triggers; by=x->x.uuid)
+    for pkgid in loaded_triggers
+        # take ownership of extids that depend on this pkgid
+        extids = pop!(EXT_DORMITORY, pkgid, nothing)
+        extids === nothing && continue
+        for extid in extids
+            if extid.ntriggers > 0
+                # It is possible that pkgid was loaded in an environment
+                # below the one of the parent. This will cause a load failure when the
+                # pkg ext tries to load the triggers. Therefore, check this first
+                # before loading the pkg ext.
+                pkgenv = Base.identify_package_env(extid.id, pkgid.name)
+                ext_not_allowed_load = false
+                if pkgenv === nothing
                     ext_not_allowed_load = true
+                else
+                    pkg, env = pkgenv
+                    path = Base.locate_package(pkg, env)
+                    if path === nothing
+                        ext_not_allowed_load = true
+                    end
+                end
+                if ext_not_allowed_load
+                    @debug "Extension $(extid.id.name) of $(extid.parentid.name) will not be loaded \
+                            since $(pkgid.name) loaded in environment lower in load path"
+                    # indicate extid is expected to fail
+                    extid.ntriggers *= -1
+                else
+                    # indicate pkgid is loaded
+                    extid.ntriggers -= 1
                 end
             end
-            if ext_not_allowed_load
-                @debug "Extension $(extid.id.name) of $(extid.parentid.name) will not be loaded \
-                        since $(pkgid.name) loaded in environment lower in load path"
-                # indicate extid is expected to fail
-                extid.ntriggers *= -1
-            else
+            if extid.ntriggers < 0
                 # indicate pkgid is loaded
-                extid.ntriggers -= 1
+                extid.ntriggers += 1
+                succeeded = false
+            else
+                succeeded = true
+            end
+            if extid.ntriggers == 0
+                # actually load extid, now that all dependencies are met,
+                # and record the result
+                succeeded = succeeded && run_extension_callbacks(extid)
+                succeeded || push!(EXT_DORMITORY_FAILED, extid)
             end
-        end
-        if extid.ntriggers < 0
-            # indicate pkgid is loaded
-            extid.ntriggers += 1
-            succeeded = false
-        else
-            succeeded = true
-        end
-        if extid.ntriggers == 0
-            # actually load extid, now that all dependencies are met,
-            # and record the result
-            succeeded = succeeded && run_extension_callbacks(extid)
-            succeeded || push!(EXT_DORMITORY_FAILED, extid)
         end
     end
-    nothing
+    return
 end
 
 """
@@ -1665,6 +1668,10 @@ function _require_prelocked(uuidkey::PkgId, env=nothing)
     else
         newm = root_module(uuidkey)
     end
+    # Load extensions when not precompiling and not in a nested package load
+    if JLOptions().incremental == 0 && isempty(package_locks)
+        run_extension_callbacks()
+    end
     return newm
 end