From f58cc59bcfcfb37fc5de21114e98b412108c8c2f Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 13 Sep 2021 03:12:22 -0400 Subject: [PATCH 1/5] CI (Buildkite): disable the experimental `asan` job --- .../experimental/launch_unsigned_builders.yml | 3 ++- .buildkite/pipelines/experimental/misc/sanitizers.yml | 10 ++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.buildkite/pipelines/experimental/launch_unsigned_builders.yml b/.buildkite/pipelines/experimental/launch_unsigned_builders.yml index f023e19a5c940..87aa41c2a85a0 100644 --- a/.buildkite/pipelines/experimental/launch_unsigned_builders.yml +++ b/.buildkite/pipelines/experimental/launch_unsigned_builders.yml @@ -1,6 +1,7 @@ steps: - label: ":buildkite: Launch unsigned pipelines" commands: | - buildkite-agent pipeline upload .buildkite/pipelines/experimental/misc/sanitizers.yml + # buildkite-agent pipeline upload .buildkite/pipelines/experimental/misc/sanitizers.yml + : agents: queue: julia diff --git a/.buildkite/pipelines/experimental/misc/sanitizers.yml b/.buildkite/pipelines/experimental/misc/sanitizers.yml index 67c0b547d4b20..05ac59069f136 100644 --- a/.buildkite/pipelines/experimental/misc/sanitizers.yml +++ b/.buildkite/pipelines/experimental/misc/sanitizers.yml @@ -20,12 +20,14 @@ steps: # `contrib/check-asan.jl` needs a `julia` binary: - JuliaCI/julia#v1: version: 1.6 + timeout_in_minutes: 120 + # notify: + # - github_commit_status: + # context: "asan" + soft_fail: + - exit_status: '*' commands: | echo "--- Build julia-debug with ASAN" contrib/asan/build.sh ./tmp/test-asan -j$${JULIA_NUM_CORES} debug echo "--- Test that ASAN is enabled" contrib/asan/check.jl ./tmp/test-asan/asan/usr/bin/julia-debug - timeout_in_minutes: 120 - # notify: # TODO: uncomment this line - # - github_commit_status: # TODO: uncomment this line - # context: "asan" # TODO: uncomment this line From 7ffad1e7539dca7a2913e4ebf56fd22033f89e55 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 13 Sep 2021 03:58:19 -0400 Subject: [PATCH 2/5] Apply suggestions from code review Co-authored-by: Takafumi Arakaki --- .buildkite/pipelines/experimental/misc/sanitizers.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.buildkite/pipelines/experimental/misc/sanitizers.yml b/.buildkite/pipelines/experimental/misc/sanitizers.yml index 05ac59069f136..500dc24eaf1a4 100644 --- a/.buildkite/pipelines/experimental/misc/sanitizers.yml +++ b/.buildkite/pipelines/experimental/misc/sanitizers.yml @@ -29,5 +29,3 @@ steps: commands: | echo "--- Build julia-debug with ASAN" contrib/asan/build.sh ./tmp/test-asan -j$${JULIA_NUM_CORES} debug - echo "--- Test that ASAN is enabled" - contrib/asan/check.jl ./tmp/test-asan/asan/usr/bin/julia-debug From aa05185f52241664f68a42bf7378497a88aa4aa1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 13 Sep 2021 03:59:34 -0400 Subject: [PATCH 3/5] Keep running the `asan` job --- .buildkite/pipelines/experimental/launch_unsigned_builders.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.buildkite/pipelines/experimental/launch_unsigned_builders.yml b/.buildkite/pipelines/experimental/launch_unsigned_builders.yml index 87aa41c2a85a0..f023e19a5c940 100644 --- a/.buildkite/pipelines/experimental/launch_unsigned_builders.yml +++ b/.buildkite/pipelines/experimental/launch_unsigned_builders.yml @@ -1,7 +1,6 @@ steps: - label: ":buildkite: Launch unsigned pipelines" commands: | - # buildkite-agent pipeline upload .buildkite/pipelines/experimental/misc/sanitizers.yml - : + buildkite-agent pipeline upload .buildkite/pipelines/experimental/misc/sanitizers.yml agents: queue: julia From 39eb16dc770dd834f0359381fe7d8525312f35f6 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 13 Sep 2021 04:00:04 -0400 Subject: [PATCH 4/5] Comment out the "soft-fail" lines --- .buildkite/pipelines/experimental/misc/sanitizers.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.buildkite/pipelines/experimental/misc/sanitizers.yml b/.buildkite/pipelines/experimental/misc/sanitizers.yml index 500dc24eaf1a4..836e41f938342 100644 --- a/.buildkite/pipelines/experimental/misc/sanitizers.yml +++ b/.buildkite/pipelines/experimental/misc/sanitizers.yml @@ -24,8 +24,8 @@ steps: # notify: # - github_commit_status: # context: "asan" - soft_fail: - - exit_status: '*' + # soft_fail: + # - exit_status: '*' commands: | echo "--- Build julia-debug with ASAN" contrib/asan/build.sh ./tmp/test-asan -j$${JULIA_NUM_CORES} debug From b8a3ec6339e6f291cff346aba9b40a4a1edd5a17 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 13 Sep 2021 05:09:21 -0400 Subject: [PATCH 5/5] Delete the commented-out "soft-fail" lines --- .buildkite/pipelines/experimental/misc/sanitizers.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.buildkite/pipelines/experimental/misc/sanitizers.yml b/.buildkite/pipelines/experimental/misc/sanitizers.yml index 836e41f938342..72d252fc34578 100644 --- a/.buildkite/pipelines/experimental/misc/sanitizers.yml +++ b/.buildkite/pipelines/experimental/misc/sanitizers.yml @@ -24,8 +24,6 @@ steps: # notify: # - github_commit_status: # context: "asan" - # soft_fail: - # - exit_status: '*' commands: | echo "--- Build julia-debug with ASAN" contrib/asan/build.sh ./tmp/test-asan -j$${JULIA_NUM_CORES} debug