From f0ff2e65cc988686b1020609211b771c42033582 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Fri, 28 Jan 2022 09:54:35 +0100 Subject: [PATCH 1/2] Fix typo in triangular --- stdlib/LinearAlgebra/src/triangular.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/LinearAlgebra/src/triangular.jl b/stdlib/LinearAlgebra/src/triangular.jl index bd0566a11b3f2..d939a5df0da01 100644 --- a/stdlib/LinearAlgebra/src/triangular.jl +++ b/stdlib/LinearAlgebra/src/triangular.jl @@ -1485,7 +1485,7 @@ end function ldiv!(xA::Union{UpperTriangular,UnitUpperTriangular}, B::UpperTriangular) return UpperTriangular(ldiv!(xA, triu!(B.data))) end -function ldiv!(xA::Union{LowerTriangular,UnitLowerTriangular}, B::UpperTriangular) +function ldiv!(xA::Union{LowerTriangular,UnitLowerTriangular}, B::LowerTriangular) return LowerTriangular(ldiv!(xA, tril!(B.data))) end From 39fc23fa474344c48b9c4a840c6d024ef9c783a3 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Fri, 28 Jan 2022 12:05:43 +0100 Subject: [PATCH 2/2] add test --- stdlib/LinearAlgebra/test/triangular.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stdlib/LinearAlgebra/test/triangular.jl b/stdlib/LinearAlgebra/test/triangular.jl index b53100c6fc654..dfb4d7c8a0b95 100644 --- a/stdlib/LinearAlgebra/test/triangular.jl +++ b/stdlib/LinearAlgebra/test/triangular.jl @@ -376,7 +376,8 @@ for elty1 in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFlo @test_throws DimensionMismatch A2' * offsizeA @test_throws DimensionMismatch A2 * offsizeA if (uplo1 == uplo2 && elty1 == elty2 != Int && t1 != UnitLowerTriangular && t1 != UnitUpperTriangular) - @test rdiv!(copy(A1), copy(A2)) ≈ A1/A2 ≈ Matrix(A1)/Matrix(A2) + @test rdiv!(copy(A1), copy(A2))::t1 ≈ A1/A2 ≈ Matrix(A1)/Matrix(A2) + @test ldiv!(copy(A2), copy(A1))::t1 ≈ A2\A1 ≈ Matrix(A2)\Matrix(A1) end if (uplo1 != uplo2 && elty1 == elty2 != Int && t2 != UnitLowerTriangular && t2 != UnitUpperTriangular) @test lmul!(adjoint(copy(A1)), copy(A2)) ≈ A1'*A2 ≈ Matrix(A1)'*Matrix(A2)