From e13f6110603135d864bd21e6a439de45d92c3aba Mon Sep 17 00:00:00 2001 From: Alexander Plavin Date: Mon, 15 Jul 2024 13:29:52 -0400 Subject: [PATCH 1/4] make Base.setindex() public --- base/tuple.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/tuple.jl b/base/tuple.jl index cc22ea75c041c..7ec6d16d068fd 100644 --- a/base/tuple.jl +++ b/base/tuple.jl @@ -52,7 +52,7 @@ julia> Base.setindex((1, 2, 6), 2, 3) == (1, 2, 2) true ``` """ -function setindex(x::Tuple, v, i::Integer) +public function setindex(x::Tuple, v, i::Integer) @boundscheck 1 <= i <= length(x) || throw(BoundsError(x, i)) @inline _setindex(v, i, x...) From a4e37819c1edf40d2a21b5550b1cb4a03b34f872 Mon Sep 17 00:00:00 2001 From: Alexander Plavin Date: Tue, 16 Jul 2024 17:03:50 -0400 Subject: [PATCH 2/4] fix syntax --- base/public.jl | 1 + base/tuple.jl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/base/public.jl b/base/public.jl index 460d3bc536383..52733c8db150a 100644 --- a/base/public.jl +++ b/base/public.jl @@ -44,6 +44,7 @@ public rest, split_rest, tail, + setindex, checked_length, elsize, diff --git a/base/tuple.jl b/base/tuple.jl index 7ec6d16d068fd..cc22ea75c041c 100644 --- a/base/tuple.jl +++ b/base/tuple.jl @@ -52,7 +52,7 @@ julia> Base.setindex((1, 2, 6), 2, 3) == (1, 2, 2) true ``` """ -public function setindex(x::Tuple, v, i::Integer) +function setindex(x::Tuple, v, i::Integer) @boundscheck 1 <= i <= length(x) || throw(BoundsError(x, i)) @inline _setindex(v, i, x...) From ab9046910e18e047fe873f20544846070a306302 Mon Sep 17 00:00:00 2001 From: Alexander Plavin Date: Wed, 24 Jul 2024 06:39:42 -0400 Subject: [PATCH 3/4] add to docs --- doc/src/base/base.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/src/base/base.md b/doc/src/base/base.md index d7e7fff7cbda7..a09a3796c5f46 100644 --- a/doc/src/base/base.md +++ b/doc/src/base/base.md @@ -151,6 +151,7 @@ Base.modifyproperty! Base.setpropertyonce! Base.propertynames Base.hasproperty +Base.setindex Core.getfield Core.setfield! Core.modifyfield! From 90e3efe3b7f1f8592519acd42ede00178f57e1eb Mon Sep 17 00:00:00 2001 From: Alexander Plavin Date: Sat, 4 Jan 2025 10:22:55 -0500 Subject: [PATCH 4/4] added a NEWS entry --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index a29fe2d43ab39..32377e15e2fce 100644 --- a/NEWS.md +++ b/NEWS.md @@ -99,6 +99,7 @@ Standard library changes ------------------------ * `gcdx(0, 0)` now returns `(0, 0, 0)` instead of `(0, 1, 0)` ([#40989]). +* `Base.setindex` function is now marked as `public` ([#55129]). #### StyledStrings