when not filtering, don't warn when loop iterator can't be eval'ed

Author: rfourquet

src/ReTest.jl

@@ -115,7 +115,7 @@ end
 function resolve!(mod::Module, ts::TestsetExpr, rx::Regex, force::Bool=false)
     strings = empty!(ts.strings)
     desc = ts.desc
-    ts.run = force
+    ts.run = force || isempty(rx.pattern)
     ts.loopvalues = nothing # unnecessary ?
 
     parentstrs = ts.parent === nothing ? [""] : ts.parent.strings
@@ -144,8 +144,10 @@ function resolve!(mod::Module, ts::TestsetExpr, rx::Regex, force::Bool=false)
             ts.loopvalues = xs
         catch
             xs = () # xs might have been assigned before the collect call
+            if !ts.run
+                @warn "could not evaluate testset-for iterator, default to inclusion"
+            end
             ts.run = true
-            @warn "could not evaluate testset-for iterator, default to inclusion"
         end
         for x in xs # empty loop if eval above threw
             ts.run && break

test/runtests.jl

@@ -198,7 +198,7 @@ end
 @test_logs (:warn, r"could not evaluate testset-for iterator.*") runtests(Loops1, r"asd")
 @test Loops1.RUN == [1, 0, 2, 0]
 empty!(Loops1.RUN)
-@test_logs (:warn, r"could not evaluate testset-for iterator.*") runtests(Loops1)
+runtests(Loops1) # should not log
 @test Loops1.RUN == [1, 0, -1, 2, 0, -1]
 
 module Loops2
@@ -226,7 +226,7 @@ end
 @test_logs (:warn, r"could not evaluate testset-for iterator.*") runtests(Loops2, r"asd")
 @test Loops2.RUN == [1, 0, 2, 0]
 empty!(Loops2.RUN)
-@test_logs (:warn, r"could not evaluate testset-for iterator.*") runtests(Loops2)
+runtests(Loops2)
 @test Loops2.RUN == [1, 0, -1, 2, 0, -1]
 
 module Loops3