Skip to content

Upgrading to 0.59.10-patch.3 crashes app #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderdave opened this issue Nov 5, 2019 · 7 comments
Closed

Upgrading to 0.59.10-patch.3 crashes app #30

coderdave opened this issue Nov 5, 2019 · 7 comments

Comments

@coderdave
Copy link

I wish I got better errors as to why it's crashing. It just says "[app] has stopped".

It was working fine with patch 0 but now I can't go back to that. I think it has something to do with
v8-android upgrading to 7.8.0?

@Kudo
Copy link
Owner

Kudo commented Nov 6, 2019

I am sorry to introduce breaking change, please try to upgrade react-native-v8 as well.

Breaking Changes

Since V8 did change their embedder API interface, original react-native-v8 will access to non existing symbol and crash.
Please upgrade react-native-v8 to one of these version.

v0.59.10-patch.3
v0.60.6-patch.1
v0.61.1-patch.2
v0.61.2-patch.0
v0.61.3-patch.0
v0.61.4-patch.0

@bhaskarGyan
Copy link

I am also facing the same issue, with v8-android 7.8.0, the app is crashing on startup but with 7.5.1 is working fine. All the other dependencies remain the same.

(Kudo/v8-android-buildscripts#2)

@Kudo
Copy link
Owner

Kudo commented Nov 6, 2019

Please let me know if the new react-native-v8 version did fix the crash issue for you. Thanks.

@wv1124
Copy link

wv1124 commented Nov 6, 2019

make sure:
"react-native-v8": "0.59.10-patch.3", => "[email protected]", ok
"react-native-v8": "0.59.10-patch.2", => "[email protected]", ok

"react-native-v8": "0.59.10-patch.2", => "[email protected]", crash

bacause: react-native-v8
"dependencies": {
"v8-android": "^7.8.0"
},

@bhaskarGyan
Copy link

bhaskarGyan commented Nov 7, 2019

@Kudo , I can confirm it is working with v0.60.6-patch.1

Thanks

@Kudo
Copy link
Owner

Kudo commented Nov 7, 2019

@bhaskarGyan Thanks for your confirmation.

Sorry to all that I was introducing yet another breaking change for #29
If you upgrade to v8-android 7.8.1,
please use any of these versions:

  • v0.59.10-patch.4
  • v0.60.6-patch.2
  • v0.61.1-patch.3
  • v0.61.2-patch.1
  • v0.61.3-patch.1
  • v0.61.4-patch.1

@Kudo
Copy link
Owner

Kudo commented Nov 29, 2019

I am going to close this issue.
Please feel free to let me know if there are any problems. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants