The functions zeros and ones now accept T as an element type

Previously the array element type could only be T if you did not
supply an element type optional parameter.  This meant that the array
type had to be known at compile time.  With this change we can now
specify all acceptable array types at run time.

Author: Symbolics

array-operations.asd

@@ -5,7 +5,7 @@
 ;;; SPDX-License-identifier: MS-PL
 
 (defsystem "array-operations"
-  :version "1.2.0"
+  :version "1.2.1"
   :description "Array operations library for Common Lisp"
   :long-description  #.(uiop:read-file-string
 			(uiop:subpathname *load-pathname* "description.text"))

src/all.lisp

@@ -2,6 +2,7 @@
 ;;; Copyright (c) 2012-2018 by Tamas Papp. All rights reserved.
 ;;; Copyright (c) 2018-2022 by Ben Dudson. All rights reserved.
 ;;; Copyright (c) 2021-2022 by Symbolics Pte. Ltd. All rights reserved.
+;;; SPDX-License-identifier: MS-PL
 
 (uiop:define-package :array-operations/all
   (:nicknames :array-operations :aops)

src/creating.lisp

@@ -42,7 +42,8 @@ Returns ARRAY."
 
 (defun zeros (dimensions &optional element-type)
   "Make an array of shape DIMENSIONS filled with zeros.  Elements are of type T, unless ELEMENT-TYPE is given."
-  (assert (subtypep element-type 'number)
+  (assert (or (eq element-type t)
+	      (subtypep element-type 'number))
 	  (element-type)
 	  "Cannot create a ZEROS array because ~A is not a numeric type." element-type)
   (if element-type
@@ -62,7 +63,8 @@ Returns ARRAY."
 
 (defun ones (dimensions &optional element-type)
   "Makes an array of shape DIMENSIONS filled with ones. Elements are of type T, unless ELEMENT-TYPE is given."
-  (assert (subtypep element-type 'number)
+  (assert (or (eq element-type t)
+	      (subtypep element-type 'number))
 	  (element-type)
 	  "Cannot create a ONES array because ~A is not a numeric type." element-type)
   (if element-type

src/matrices.lisp

@@ -2,20 +2,20 @@
 ;;; Copyright (c) 2012-2018 by Tamas Papp. All rights reserved.
 ;;; Copyright (c) 2018-2022 by Ben Dudson. All rights reserved.
 ;;; Copyright (c) 2021-2022 by Symbolics Pte. Ltd. All rights reserved.
+;;; SPDX-License-identifier: MS-PL
 
-(defpackage :array-operations/matrices
+(uiop:define-package #:array-operations/matrices
   (:use :cl :array-operations/generic)
-  (:import-from :alexandria
-                :length=)
-  (:export :array-matrix
-           :matrixp
-           :square-matrix-p
+  (:import-from #:alexandria #:length=)
+  (:export #:array-matrix
+           #:matrixp
+           #:square-matrix-p
            ;; the next two are deprecated aliases for the previous two
-           :matrix?
-           :square-matrix?)
+           #:matrix?
+           #:square-matrix?)
   (:documentation "Functions for representing matrices as 2D arrays.  A matrix is a two-dimensional array often used for linear algebra.  See also the matrix functions in NUM-UTILS,  which should be migrated to AOPS."))
 
-(in-package :array-operations/matrices)
+(in-package #:array-operations/matrices)
 
 (deftype array-matrix ()
   "A rank-2 array."

tests/tests.lisp

@@ -2,12 +2,13 @@
 ;;; Copyright (c) 2012-2018 by Tamas Papp. All rights reserved.
 ;;; Copyright (c) 2018-2022 by Ben Dudson. All rights reserved.
 ;;; Copyright (c) 2021-2023 by Symbolics Pte. Ltd. All rights reserved.
+;;; SPDX-License-identifier: MS-PL
 
-(defpackage :array-operations/tests
+(uiop:define-package #:array-operations/tests
   (:use :cl :alexandria :clunit)
-  (:export :run))
+  (:export #:run))
 
-(cl:in-package :array-operations/tests)
+(in-package #:array-operations/tests)
 
 (defsuite tests ())
 (defsuite creation (tests))
@@ -439,7 +440,6 @@
     (assert-equalp #(9 12 15)
         (aops:vectorize (a b) (+ a (* b 2))))))
 
-
 (deftest turn (transformations)
   (let ((array-1 #2A((1 0 0)
                      (2 0 0)