From 30e1d09bbb1874036e180fbde9f44db4b2f84ce6 Mon Sep 17 00:00:00 2001 From: sam detweiler Date: Tue, 10 Dec 2024 16:19:19 -0600 Subject: [PATCH 1/3] fix access denied crash writing js/positions.js #3651 --- CHANGELOG.md | 1 + js/utils.js | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 18e8f9ebd9..edc6d91e44 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ _This release is scheduled to be released on 2025-01-01._ - [core] Run code style checks in workflow only once. - [core] fix animations export #3644 only on server side +- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing, positions list empty ### Removed diff --git a/js/utils.js b/js/utils.js index 9536a1b070..d4b90223ed 100644 --- a/js/utils.js +++ b/js/utils.js @@ -65,7 +65,12 @@ module.exports = { modulePositions.push(positionName); } }); - fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`); + try { + fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`); + } + catch (error) { + console.error("unable to write js/positions.js with the discovered module positions\nmake the MagicMirror/js folder writeable by the user starting MagicMirror"); + } } // return the list to the caller return modulePositions; From 96f05814f2c8ee23bdbd203739dfe9d4b7f0525f Mon Sep 17 00:00:00 2001 From: sam detweiler Date: Wed, 18 Dec 2024 10:09:47 -0600 Subject: [PATCH 2/3] Update CHANGELOG.md remove line wrap --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e2258fb0bb..d70623179a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,7 +30,7 @@ _This release is scheduled to be released on 2025-01-01._ - [core] Run code style checks in workflow only once (#3648) - [core] Fix animations export #3644 only on server side (#3649) - [core] Use project URL in fallback config. -- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing, positions list empty +- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing ### Removed From 49723b396cd3d459682c076c5e3df7adbd084084 Mon Sep 17 00:00:00 2001 From: sam detweiler Date: Wed, 18 Dec 2024 10:13:34 -0600 Subject: [PATCH 3/3] fix changelog error --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d70623179a..c19de0a317 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,7 +32,6 @@ _This release is scheduled to be released on 2025-01-01._ - [core] Use project URL in fallback config. - [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing - ### Removed - [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575)