Skip to content

throttle $/progress #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prabirshrestha opened this issue Feb 28, 2021 · 1 comment
Closed

throttle $/progress #772

prabirshrestha opened this issue Feb 28, 2021 · 1 comment

Comments

@prabirshrestha
Copy link

Issue was originally reported at prabirshrestha/vim-lsp#1073. On digging further it seems that ccls is sending too many $/progress notifications. VimScript being slow and running in the same UI thread it causes vim to be very slow. It would be good if $/progress notifications can be throttled.

Here is the log. https://github.com/prabirshrestha/vim-lsp/files/6055035/vim-lsp-with-issue.log

Percentage doesn't change so the client is unnecessarily parsing the message, decoding and updating the ui status bar causing it to be very slow.

Sat 27 Feb 2021 11:04:41 PM IST:["<---", 5, "ccls", {"response": {"method": "$/progress", "jsonrpc": "2.0", "params": {"token": "index", "value": {"percentage": 0.011531, "message": "1/8672", "kind": "report"}}}}]
Sat 27 Feb 2021 11:04:41 PM IST:["<---", 5, "ccls", {"response": {"method": "$/progress", "jsonrpc": "2.0", "params": {"token": "index", "value": {"percentage": 0.011531, "message": "1/8672", "kind": "report"}}}}]
Sat 27 Feb 2021 11:04:41 PM IST:["<---", 5, "ccls", {"response": {"method": "$/progress", "jsonrpc": "2.0", "params": {"token": "index", "value": {"percentage": 0.011531, "message": "1/8672", "kind": "report"}}}}]

I reported something similar to rust-analyzer. rust-lang/rust-analyzer#7590

@joelhock
Copy link

this should already be fixed by #734 (comment)

@MaskRay MaskRay closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants