Skip to content

Commit 0e41eba

Browse files
raunaqsserquhart
authored andcommitted
resolve console warnings, add meta description tag to blog posts (#131)
1 parent 87a0d00 commit 0e41eba

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

src/components/Features.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const FeatureGrid = ({ gridItems }) => (
1414
display: 'inline-block',
1515
}}
1616
>
17-
<PreviewCompatibleImage imageInfo={item.image} />
17+
<PreviewCompatibleImage imageInfo={item} />
1818
</div>
1919
</div>
2020
<p>{item.text}</p>

src/pages/contact/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@ export default class Index extends React.Component {
5959
<div className="field">
6060
<label className="label" htmlFor={"name"} >Your name</label>
6161
<div className="control">
62-
<input className="input" type={"text"} name={"name"} onChange={this.handleChange} id={"name"} required={"true"} />
62+
<input className="input" type={"text"} name={"name"} onChange={this.handleChange} id={"name"} required={true} />
6363
</div>
6464
</div>
6565
<div className="field">
6666
<label className="label" htmlFor={"email"}>Email</label>
6767
<div className="control">
68-
<input className="input" type={"email"} name={"email"} onChange={this.handleChange} id={"email"} required={"true"} />
68+
<input className="input" type={"email"} name={"email"} onChange={this.handleChange} id={"email"} required={true} />
6969
</div>
7070
</div>
7171
<div className="field">
7272
<label className="label" htmlFor={"message"}>Message</label>
7373
<div className="control">
74-
<textarea className="textarea" name={"message"} onChange={this.handleChange} id={"email"} required={"true"} />
74+
<textarea className="textarea" name={"message"} onChange={this.handleChange} id={"email"} required={true} />
7575
</div>
7676
</div>
7777
<div className="field">

src/templates/blog-post.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ BlogPostTemplate.propTypes = {
5151
contentComponent: PropTypes.func,
5252
description: PropTypes.string,
5353
title: PropTypes.string,
54-
helmet: PropTypes.instanceOf(Helmet),
54+
helmet: PropTypes.object,
5555
}
5656

5757
const BlogPost = ({ data }) => {
@@ -63,7 +63,14 @@ const BlogPost = ({ data }) => {
6363
content={post.html}
6464
contentComponent={HTMLContent}
6565
description={post.frontmatter.description}
66-
helmet={<Helmet title={`${post.frontmatter.title} | Blog`} />}
66+
helmet={
67+
<Helmet
68+
titleTemplate="%s | Blog"
69+
>
70+
<title>{`${post.frontmatter.title}`}</title>
71+
<meta name="description" content={`${post.frontmatter.description}`} />
72+
</Helmet>
73+
}
6774
tags={post.frontmatter.tags}
6875
title={post.frontmatter.title}
6976
/>

0 commit comments

Comments
 (0)