Skip to content

Commit 8347a2a

Browse files
committed
Revert "Convert BaseConfig, BaseState` interfaces to types"
This reverts commit 93a997b.
1 parent 0a66987 commit 8347a2a

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

packages/base-controller/CHANGELOG.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10-
### Changed
11-
12-
- **BREAKING:** Convert `BaseConfig`, `BaseState` interfaces to types ([#3959](https://github.com/MetaMask/core/pull/3959))
13-
- As types, `BaseConfig`, `BaseState` now extend `Record` and have an index signature of `string`.
14-
1510
## [4.1.1]
1611

1712
### Changed

packages/base-controller/src/BaseControllerV1.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,25 @@ export type Listener<T> = (state: T) => void;
99
* Base controller configuration
1010
* @property disabled - Determines if this controller is enabled
1111
*/
12-
export type BaseConfig = {
12+
// This interface was created before this ESLint rule was added.
13+
// Convert to a `type` in a future major version.
14+
// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
15+
export interface BaseConfig {
1316
disabled?: boolean;
14-
};
17+
}
1518

1619
/**
1720
* @type BaseState
1821
*
1922
* Base state representation
2023
* @property name - Unique name for this controller
2124
*/
22-
export type BaseState = {
25+
// This interface was created before this ESLint rule was added.
26+
// Convert to a `type` in a future major version.
27+
// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
28+
export interface BaseState {
2329
name?: string;
24-
};
30+
}
2531

2632
/**
2733
* @deprecated This class has been renamed to BaseControllerV1 and is no longer recommended for use for controllers. Please use BaseController (formerly BaseControllerV2) instead.

0 commit comments

Comments
 (0)