Skip to content

Couple snap_manageAccounts to endowment:keyring #2798

@FrederikBolding

Description

@FrederikBolding

snap_manageAccounts is only supposed to be used by Snaps that implement the keyring API, thus we don't need two separate permissions for this.

We should figure out a way to make snap_manageAccounts not a permission anymore, but instead an RPC method gated by endowment:keyring. E.g.

if (!hasPermission(SnapEndowments.EthereumProvider)) {
return end(rpcErrors.methodNotFound());
}

This needs to be done in a backwards compatible way.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions