Proposal: Date support

[4F2E4A2E]

I propose to add Date support using this implementation, found here graphql/graphql-js#550

[MichalLytek]

Honestly, I prefer the ISO version of the Date scalar, it's human readable and easier to debug:

import { GraphQLScalarType, Kind } from "graphql";

export const DateScalar = new GraphQLScalarType({
  name: "Date",
  description: "Date scalar type",
  parseValue(value: string) {
    return new Date(value); // value from the client input variables
  },
  serialize(value: Date) {
    return value.toISOString(); // value sent to the client
  },
  parseLiteral(ast) {
    if (ast.kind === Kind.STRING) {
      return new Date(ast.value); // value from the client query
    }
    return null;
  },
});

And because I don't want to make this framework so opinionated, I prefer to gave developers freedom to use their own version of Date and other scalars with #5 custom scalar support 😉

[4F2E4A2E]

You are right. I will change it to the iso format.

[4F2E4A2E]

A default date speeds up the getting started, but of course, passing in the custom scalar type as presented by you is just fine too:

import { GraphQLScalarType, Kind } from 'graphql';
import { Field, GraphQLObjectType } from 'type-graphql';

export const DateScalar = new GraphQLScalarType({
  name:        'Date',
  description: 'Date scalar type',
  parseValue(value: string) {
    return new Date(value); // value from the client input variables
  },
  serialize(value: Date) {
    return value.toISOString(); // value sent to the client
  },
  parseLiteral(ast) {
    if (ast.kind === Kind.STRING) {
      return new Date(ast.value); // value from the client query
    }
    return null;
  }
});

@GraphQLObjectType()
export class User {
  @Field(type => DateScalar)
  contributorsince: Date;
  @Field()
  alive: boolean;
}

[MichalLytek]

Closing - implemented in ba21848 😉