Skip to content

added channels to connector #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 10, 2018
Merged

added channels to connector #1005

merged 8 commits into from
Oct 10, 2018

Conversation

JasonSowers
Copy link
Contributor

@coveralls
Copy link
Collaborator

coveralls commented Oct 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 41075

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 48.048%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/Channel.cs 6 71.43%
Totals Coverage Status
Change from base Build 41025: 0.0%
Covered Lines: 4430
Relevant Lines: 9220
💛 - Coveralls

@JasonSowers JasonSowers mentioned this pull request Oct 5, 2018
Closed
@JasonSowers
Copy link
Contributor Author

working on js/ts next

cleemullins
cleemullins previously requested changes Oct 8, 2018
View reviewed changes
@benbrown benbrown dismissed cleemullins’s stale review October 9, 2018 20:58

In person review

@JasonSowers JasonSowers merged commit 2cadc45 into master Oct 10, 2018
@yochay yochay added bug Indicates an unexpected problem or an unintended behavior. Approved 4.1 October 31, 2018 Release labels Oct 29, 2018
tomlm pushed a commit that referenced this pull request Nov 27, 2018
@JasonSowers
Merge pull request #1005 from Microsoft/jassow-channels
7a6d040 
added channels to connector
@cleemullins cleemullins deleted the jassow-channels branch March 5, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins left review comments

@johnataylor johnataylor Awaiting requested review from johnataylor

+1 more reviewer

@benbrown benbrown benbrown approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
4.1 October 31, 2018 Release bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JasonSowers @coveralls @benbrown @cleemullins @yochay @stevengum