Skip to content

Conversation

cleemullins
Copy link
Contributor

I've done the following in this build:

  1. Moved duplicate attributes into the common file.
  2. Test projects no longer generate docs.
  3. Test projects no longer generate NuGet Packages.
  4. Reverted doc file generation to defaults (which is correct anyway).
  5. Cleaned up unexpected warning / settings.
  6. Removed PackageId and AssemblyName and DefaultNamespace attributes that are not needed (defaults are correct)

The resulting .csproj files are quite a bit cleaner now than they were. There's still room for improvement...

@@ -21,19 +20,7 @@
<AssemblyOriginatorKeyFile>..\..\..\build\35MSSharedLib1024.snk</AssemblyOriginatorKeyFile>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should you move this <AssemblyOriginatorKeyFile> up to DirectoryBuild.props as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, as the various Integration packages would then have the wrong paths. Likewise, I don't want to strong-name the test projects.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 47696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 55.845%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder/Integration/BotFrameworkOptions.cs 3 63.64%
Totals Coverage Status
Change from base Build 47688: 0.01%
Covered Lines: 5508
Relevant Lines: 9863

💛 - Coveralls

@cleemullins cleemullins merged commit 497e2a4 into master Jan 28, 2019
@cleemullins cleemullins deleted the CLM/ProjectFileCleanup branch January 28, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants