You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+12-8Lines changed: 12 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -41,14 +41,18 @@ Please list clearly what are the relevant test(s) that can safeguard the changes
41
41
-->
42
42
43
43
## PR Checklist
44
-
Please check the following items wherever appropriate, else strick them out if N/A. This is needed to merge the PR.
45
-
All items must be resolved either by checking boxes or striking the line if N/A. This will be needed to merge the PR.
46
-
-[ ] Have you made sure the PR description is explaining what you’re doing and why?
47
-
-[ ] Are you following the [TRT-LLM CODING GUIDELINES](https://github.com/NVIDIA/TensorRT-LLM/blob/main/CODING_GUIDELINES.md) to the best of your knowledge?
48
-
-[ ] Do you have test cases for new code paths? See https://github.com/NVIDIA/TensorRT-LLM/tree/main/tests#1-how-does-the-ci-work for instructions on how to add.
49
-
-[ ] Have you introduced any new dependencies? If so, please make sure that scans have been run for license permissiveness and vulnerability issues recursively for the dependency and its dependencies.
50
-
-[ ] Have you updated https://github.com/NVIDIA/TensorRT-LLM/blob/main/.github/CODEOWNERS to reflect any changes in ownership due to your PR?
51
-
-[ ] Have you updated any documentation that is associated with your change?
44
+
45
+
Please review the following before submitting your PR:
46
+
- PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
47
+
- PR Follows [TRT-LLM CODING GUIDELINES](https://github.com/NVIDIA/TensorRT-LLM/blob/main/CODING_GUIDELINES.md) to the best of your knowledge.
48
+
- Test cases are provided for new code paths (see [test instructions](https://github.com/NVIDIA/TensorRT-LLM/tree/main/tests#1-how-does-the-ci-work))
49
+
- Any new dependencies have been scanned for license and vulnerabilities
50
+
-[CODEOWNERS](https://github.com/NVIDIA/TensorRT-LLM/blob/main/.github/CODEOWNERS) updated if ownership changes
51
+
- Documentation updated as needed
52
+
- The reviewers assigned automatically/manually are appropriate for the PR.
53
+
54
+
55
+
-[ ] Please check this after reviewing the above items as appropriate for this PR.
0 commit comments