This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

/ok to test 3978a2f

/ok to test 58c6f9d

/ok to test 05b63d2

/ok to test 15525a7

@kkraus14 @aterrel this should be ready now

LGTM based on what I see under GH "Files changed"

I had the idea to look at the doc preview:

In cuda_bindings/docs/source/index.rst I see this list with 11 items:

   release                                                                      
   install.md                                                                   
   overview.md                                                                  
   motivation.md                                                                
   environment_variables.md                                                     
   api                                                                          
   tips_and_tricks                                                              
   support                                                                      
   contribute.md                                                                
   conduct.md                                                                   
   license                                                                      

Under https://nvidia.github.io/cuda-python/cuda-bindings/latest/ I only see the first 8 items in the side bar, the last 3 are not there. Is that intentional?

It's the same already under https://nvidia.github.io/cuda-python/cuda-bindings/

I.e. without latest/ in the URL.

I am sure we discussed this 😛 the latest docs is updated after a PR is merged into main, not before. AFAIK this is universal behavior with respect to e.g. Read the Docs too. This is why we set up the doc preview CI: #583 (comment)

I am sure we discussed this 😛 the latest docs is updated after a PR is merged into main, not before. AFAIK this is universal behavior with respect to e.g. Read the Docs too. This is why we set up the doc preview CI: #583 (comment)

Oh, I thought I used that link! — I must have fallen off the track when clicking around. Sorry.

No worries at all! There exists a few rough edges in the doc preview I am not happy about, that could lead to what you observed. For example, in some of the places we hard-wire the urls that point to latest. Also because we stitch all the component docs together, the cross links do not respect the url change (having pr-XXX as part of the url). This is why the CI message needs to leave 3 urls instead of 1 🥲 some love is needed for improving it...

Do we need/want contribut.* for cuda-python?

$ git status
On branch license_change
Your branch is up to date with 'leofang/license_change'.

$ find . -type f -name contribut*
./cuda_core/docs/source/contribute.rst
./cuda_bindings/docs/source/contribute.md

I removed it because of #234, but I could use some second opinions here 🙂Let me know what you think...

Minor and unrelated, but JIC you want to fix it while you're at it:

I don't know how those cuda-python v etc. are generated. It looks odd. Maybe just delete the v?

I removed it because of #234, but I could use some second opinions here 🙂Let me know what you think...

Got it, thanks! — I don't have an opinion. Only this much: Might be nice to have for completeness, but not sure if it's worth anyone's time.

I don't know how those cuda-python v etc. are generated. It looks odd. Maybe just delete the v?

Yes, this comes from our own html hack to enable the hidden version selector capability. I opened #587.