Skip to content

Commit 8b3026f

Browse files
triniwiztriniwiz
committed
fix(firestore): writebatch
fixes: #62
1 parent 225042a commit 8b3026f

File tree

18 files changed

+26
-26
lines changed

18 files changed

+26
-26
lines changed

‎packages/firebase-admob/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-admob",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Admob",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-analytics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-analytics",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Analytics",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-app-check/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-app-check",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - App Check",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-auth/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-auth",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Auth",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-core",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Core",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-crashlytics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-crashlytics",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Crashlytics",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-database/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-database",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Database",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-dynamic-links/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-dynamic-links",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Dynamic Links",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-firestore/index.android.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ICollectionReference, IDocumentReference, IFieldPath, IFieldValue, IGeo
22

33
export { SetOptions, DocumentData, GetOptions, WhereFilterOp };
44

5-
import { deserialize, firebase, FirebaseApp, FirebaseError, serialize } from '@nativescript/firebase-core';
5+
import { firebase, FirebaseApp, FirebaseError, serialize } from '@nativescript/firebase-core';
66

77
let defaultFirestore: Firestore;
88

@@ -1371,23 +1371,23 @@ export class WriteBatch implements IWriteBatch {
13711371
if (options) {
13721372
if (typeof options?.merge === 'boolean') {
13731373
const opts = com.google.firebase.firestore.SetOptions.merge();
1374-
return WriteBatch.fromNative(this.native.set(serialize(data), documentRef.native, opts));
1374+
return WriteBatch.fromNative(this.native.set(serializeItems(data), documentRef.native, opts));
13751375
}
13761376

13771377
if (options.mergeFields) {
13781378
if (Array.isArray(options.mergeFields)) {
13791379
if (typeof options.mergeFields[0] === 'string') {
1380-
return WriteBatch.fromNative(this.native.set(serialize(data), documentRef.native, com.google.firebase.firestore.SetOptions.mergeFields(options.mergeFields as any)));
1380+
return WriteBatch.fromNative(this.native.set(serializeItems(data), documentRef.native, com.google.firebase.firestore.SetOptions.mergeFields(options.mergeFields as any)));
13811381
}
13821382

13831383
const list = java.util.Arrays.asList(options.mergeFields.map((field) => field.native));
1384-
return WriteBatch.fromNative(this.native.set(serialize(data), documentRef.native, com.google.firebase.firestore.SetOptions.mergeFields(list)));
1384+
return WriteBatch.fromNative(this.native.set(serializeItems(data), documentRef.native, com.google.firebase.firestore.SetOptions.mergeFields(list)));
13851385
}
13861386
}
13871387

13881388
return null;
13891389
} else {
1390-
return WriteBatch.fromNative(this.native.set(serialize(data), documentRef.native));
1390+
return WriteBatch.fromNative(this.native.set(serializeItems(data), documentRef.native));
13911391
}
13921392
}
13931393

‎packages/firebase-firestore/index.ios.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ICollectionReference, IDocumentReference, IFieldPath, IFieldValue, IGeo
22

33
const main_queue = dispatch_get_current_queue();
44

5-
import { deserialize, firebase, FirebaseApp, FirebaseError, serialize } from '@nativescript/firebase-core';
5+
import { firebase, FirebaseApp, FirebaseError, serialize } from '@nativescript/firebase-core';
66

77
let defaultFirestore: Firestore;
88

@@ -1190,18 +1190,18 @@ export class WriteBatch implements IWriteBatch {
11901190
set(documentRef: DocumentReference, data: DocumentData, options?: SetOptions): WriteBatch {
11911191
if (options) {
11921192
if (typeof options?.merge === 'boolean') {
1193-
return WriteBatch.fromNative(this.native.setDataForDocumentMerge(serialize(data), documentRef.native, options.merge));
1193+
return WriteBatch.fromNative(this.native.setDataForDocumentMerge(serializeItems(data), documentRef.native, options.merge));
11941194
}
11951195

11961196
if (options.mergeFields) {
11971197
if (Array.isArray(options.mergeFields)) {
11981198
if (typeof options.mergeFields[0] === 'string') {
1199-
return WriteBatch.fromNative(this.native.setDataForDocumentMergeFields(serialize(data), documentRef.native, options.mergeFields));
1199+
return WriteBatch.fromNative(this.native.setDataForDocumentMergeFields(serializeItems(data), documentRef.native, options.mergeFields));
12001200
}
12011201

12021202
return WriteBatch.fromNative(
12031203
this.native.setDataForDocumentMergeFields(
1204-
serialize(data),
1204+
serializeItems(data),
12051205
documentRef.native,
12061206
options.mergeFields.map((field) => field.native)
12071207
)
@@ -1211,7 +1211,7 @@ export class WriteBatch implements IWriteBatch {
12111211

12121212
return null;
12131213
} else {
1214-
return WriteBatch.fromNative(this.native.setDataForDocument(serialize(data), documentRef.native));
1214+
return WriteBatch.fromNative(this.native.setDataForDocument(serializeItems(data), documentRef.native));
12151215
}
12161216
}
12171217

‎packages/firebase-firestore/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-firestore",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Firestore",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-functions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-functions",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Functions",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-in-app-messaging/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-in-app-messaging",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - In App Messaging",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-installations/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-installations",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Installations",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-messaging/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-messaging",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Messaging",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-performance/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-performance",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Performancee",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-remote-config/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-remote-config",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Remote Config",
55
"main": "index",
66
"typings": "index.d.ts",

‎packages/firebase-storage/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nativescript/firebase-storage",
3-
"version": "1.0.4",
3+
"version": "1.0.5",
44
"description": "NativeScript Firebase - Storage",
55
"main": "index",
66
"typings": "index.d.ts",

0 commit comments

Comments
 (0)