From 16642aa7ee470e254932edb84ed7d9be0716e4c7 Mon Sep 17 00:00:00 2001 From: Osei Fortune Date: Tue, 23 Nov 2021 18:19:57 -0400 Subject: [PATCH] fix: detection event fixes #5 --- apps/demo/src/plugin-demos/mlkit-core.ts | 6 +- apps/demo/src/plugin-demos/mlkit-core.xml | 2 +- .../{index.d.ts => index.ts} | 21 ++++- packages/mlkit-barcode-scanning/package.json | 2 +- packages/mlkit-core/README.md | 44 ++++----- packages/mlkit-core/common.ts | 9 +- packages/mlkit-core/index.android.ts | 90 ++++++++++++++++--- packages/mlkit-core/index.d.ts | 10 ++- packages/mlkit-core/index.ios.ts | 53 ++++++----- packages/mlkit-core/package.json | 2 +- .../{index.d.ts => index.ts} | 0 .../{index.d.ts => index.ts} | 0 packages/mlkit-face-detection/package.json | 2 +- .../{index.d.ts => index.ts} | 0 packages/mlkit-image-labeling/package.json | 2 +- .../{index.d.ts => index.ts} | 0 packages/mlkit-object-detection/package.json | 2 +- .../{index.d.ts => index.ts} | 0 packages/mlkit-pose-detection/package.json | 2 +- .../{index.d.ts => index.ts} | 0 packages/mlkit-text-recognition/package.json | 2 +- workspace.json | 21 ++--- 22 files changed, 180 insertions(+), 90 deletions(-) rename packages/mlkit-barcode-scanning/{index.d.ts => index.ts} (86%) rename packages/mlkit-digital-ink-recognition/{index.d.ts => index.ts} (100%) rename packages/mlkit-face-detection/{index.d.ts => index.ts} (100%) rename packages/mlkit-image-labeling/{index.d.ts => index.ts} (100%) rename packages/mlkit-object-detection/{index.d.ts => index.ts} (100%) rename packages/mlkit-pose-detection/{index.d.ts => index.ts} (100%) rename packages/mlkit-text-recognition/{index.d.ts => index.ts} (100%) diff --git a/apps/demo/src/plugin-demos/mlkit-core.ts b/apps/demo/src/plugin-demos/mlkit-core.ts index 7d9f272..9e20c43 100644 --- a/apps/demo/src/plugin-demos/mlkit-core.ts +++ b/apps/demo/src/plugin-demos/mlkit-core.ts @@ -1,6 +1,6 @@ import { Observable, EventData, Page, Dialogs } from '@nativescript/core'; import { DemoSharedMlkitCore } from '@demo/shared'; -import { DetectionType, MLKitView } from '@nativescript/mlkit-core'; +import { DetectionType, MLKitView, DetectionEvent } from '@nativescript/mlkit-core'; import { BarcodeResult } from '@nativescript/mlkit-barcode-scanning'; import { FaceResult } from '@nativescript/mlkit-face-detection'; import { ImageLabelingResult } from '@nativescript/mlkit-image-labeling'; @@ -20,8 +20,8 @@ export class DemoModel extends DemoSharedMlkitCore { this.camera = args.object; } - onDetection(data, type: DetectionType) { - console.log('onDetection', data, type); + onDetection(event: DetectionEvent) { + console.log('onDetection', event.data, event.type); } toggleCamera() { diff --git a/apps/demo/src/plugin-demos/mlkit-core.xml b/apps/demo/src/plugin-demos/mlkit-core.xml index 7dd59a9..bd63e52 100644 --- a/apps/demo/src/plugin-demos/mlkit-core.xml +++ b/apps/demo/src/plugin-demos/mlkit-core.xml @@ -4,7 +4,7 @@ - +