Skip to content

Commit 145086c

Browse files
author
Dimitar Tachev
authored
Merge pull request #123 from NativeScript/radeva/update-readme
chore: update readme
2 parents 9a9a085 + 5f0853e commit 145086c

File tree

4 files changed

+148
-0
lines changed

4 files changed

+148
-0
lines changed

.github/issue_template.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
### Make sure to check the demo app(s) for sample usage
2+
3+
### Make sure to check the existing issues in this repository
4+
5+
### If the demo apps cannot help and there is no issue for your problem, tell us about it
6+
Please, ensure your title is less than 63 characters long and starts with a capital
7+
letter.
8+
9+
### Which platform(s) does your issue occur on?
10+
- iOS/Android/Both
11+
- iOS/Android versions
12+
- emulator or device. What type of device?
13+
14+
### Please, provide the following version numbers that your issue occurs with:
15+
16+
- CLI: (run `tns --version` to fetch it)
17+
- Cross-platform modules: (check the 'version' attribute in the
18+
`node_modules/tns-core-modules/package.json` file in your project)
19+
- Runtime(s): (look for the `"tns-android"` and `"tns-ios"` properties in the `package.json` file of your project)
20+
- Plugin(s): (look for the version numbers in the `package.json` file of your
21+
project and paste your dependencies and devDependencies here)
22+
23+
### Please, tell us how to recreate the issue in as much detail as possible.
24+
Describe the steps to reproduce it.
25+
26+
### Is there any code involved?
27+
- provide a code example to recreate the problem
28+
- (EVEN BETTER) provide a .zip with application or refer to a repository with application where the problem is reproducible.

.github/pull_request_template.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<!--
2+
We, the rest of the NativeScript community, thank you for your
3+
contribution!
4+
To help the rest of the community review your change, please follow the instructions in the template.
5+
-->
6+
7+
<!-- PULL REQUEST TEMPLATE -->
8+
<!-- (Update "[ ]" to "[x]" to check a box) -->
9+
10+
## PR Checklist
11+
12+
- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
13+
- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
14+
- [ ] All existing tests are passing
15+
- [ ] Tests for the changes are included
16+
17+
## What is the current behavior?
18+
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
19+
20+
## What is the new behavior?
21+
<!-- Describe the changes. -->
22+
23+
Fixes/Implements/Closes #[Issue Number].
24+
25+
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
26+
27+
<!--
28+
BREAKING CHANGES:
29+
30+
31+
[Describe the impact of the changes here.]
32+
33+
Migration steps:
34+
[Provide a migration path for existing applications.]
35+
-->
36+

CONTRIBUTING.md

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
# Contributing to NativeScript Background HTTP
2+
3+
:+1: First of all, thank you for taking the time to contribute! :+1:
4+
5+
Here are some guides on how to do that:
6+
7+
<!-- TOC depthFrom:2 -->
8+
9+
- [Code of Conduct](#code-of-conduct)
10+
- [Reporting Bugs](#reporting-bugs)
11+
- [Requesting Features](#requesting-features)
12+
- [Submitting a PR](#submitting-a-pr)
13+
- [Where to Start](#where-to-start)
14+
15+
<!-- /TOC -->
16+
17+
## Code of Conduct
18+
Help us keep a healthy and open community. We expect all participants in this project to adhere to the [NativeScript Code Of Conduct](https://github.com/NativeScript/codeofconduct).
19+
20+
21+
## Reporting Bugs
22+
23+
1. Always update to the most recent master release; the bug may already be resolved.
24+
2. Search for similar issues in the issues list for this repo; it may already be an identified problem.
25+
3. If this is a bug or problem that is clear, simple, and is unlikely to require any discussion -- it is OK to open an issue on GitHub with a reproduction of the bug including workflows and screenshots. If possible, submit a Pull Request with a failing test, entire application or module. If you'd rather take matters into your own hands, fix the bug yourself (jump down to the [Submitting a PR](#submitting-a-pr) section).
26+
27+
## Requesting Features
28+
29+
1. Use Github Issues to submit feature requests.
30+
2. First, search for a similar request and extend it if applicable. This way it would be easier for the community to track the features.
31+
3. When requesting a new feature, please provide as much detail as possible about why you need the feature in your apps. We prefer that you explain a need rather than explain a technical solution for it. That might trigger a nice conversation on finding the best and broadest technical solution to a specific need.
32+
33+
## Submitting a PR
34+
35+
Before you begin make sure there is an issue for the bug or feature you will be working on.
36+
37+
Following these steps is the best way to get your code included in the project:
38+
39+
1. Fork and clone the nativescript-background-http repo:
40+
```bash
41+
git clone https://github.com/NativeScript/nativescript-background-http.git
42+
# Navigate to the newly cloned directory
43+
cd nativescript-background-http
44+
# Add an "upstream" remote pointing to the original repo.
45+
git remote add upstream https://github.com/NativeScript/nativescript-background-http.git
46+
```
47+
48+
2. Read our [development workflow guide](DevelopmentWorkflow.md) for local setup
49+
50+
3. Create a branch for your PR
51+
```bash
52+
git checkout -b <my-fix-branch> master
53+
```
54+
55+
4. The fun part! Make your code changes. Make sure you:
56+
- Follow the [code conventions guide](https://github.com/NativeScript/NativeScript/blob/master/CodingConvention.md).
57+
- Follow the [commit message guidelines](https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages)
58+
- Update the README if you make changes to the plugin API
59+
60+
5. Before you submit your PR:
61+
- Rebase your changes to the latest master: `git pull --rebase upstream master`.
62+
- Ensure your changes pass tslint validation. (run `npm run tslint` in the `src` folder).
63+
64+
6. Push your fork. If you have rebased you might have to use force-push your branch:
65+
```
66+
git push origin <my-fix-branch> --force
67+
```
68+
69+
7. [Submit your pull request](https://github.com/NativeScript/nativescript-background-http/compare) and compare to `NativeScript/nativescript-background-http`. Please, fill in the Pull Request template - it will help us better understand the PR and increase the chances of it getting merged quickly.
70+
71+
It's our turn from there on! We will review the PR and discuss changes you might have to make before merging it! Thanks!
72+
73+
## Where to Start
74+
75+
If you want to contribute, but you are not sure where to start - look for issues labeled [`help wanted`](https://github.com/NativeScript/nativescript-background-http/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22).

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,12 @@ var params = [
8484
];
8585
task = session.multipartUpload(params, request);
8686
```
87+
88+
## Contribute
89+
We love PRs! Check out the [contributing guidelines](CONTRIBUTING.md). If you want to contribute, but you are not sure where to start - look for [issues labeled `help wanted`](https://github.com/NativeScript/nativescript-background-http/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22).
90+
91+
## Get Help
92+
Please, use [github issues](https://github.com/NativeScript/nativescript-background-http/issues) strictly for [reporting bugs](CONTRIBUTING.md#reporting-bugs) or [requesting features](CONTRIBUTING.md#requesting-new-features). For general questions and support, check out the [NativeScript community forum](https://discourse.nativescript.org/) or ask our experts in [NativeScript community Slack channel](http://developer.telerik.com/wp-login.php?action=slack-invitation).
93+
94+
![](https://ga-beacon.appspot.com/UA-111455-24/nativescript/nativescript-background-http?pixel)
95+

0 commit comments

Comments
 (0)