From c1eb4b9ee63085ca7f0374e3f53d71c6638b645b Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Fri, 3 Sep 2021 12:43:13 +0200 Subject: [PATCH 1/2] fix: xcodebuild destination warning --- lib/services/ios/xcodebuild-args-service.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/services/ios/xcodebuild-args-service.ts b/lib/services/ios/xcodebuild-args-service.ts index 6af3032022..766e83a46d 100644 --- a/lib/services/ios/xcodebuild-args-service.ts +++ b/lib/services/ios/xcodebuild-args-service.ts @@ -38,17 +38,15 @@ export class XcodebuildArgsService implements IXcodebuildArgsService { let productType: ProductArgs; if (this.$iOSWatchAppService.hasWatchApp(platformData, projectData)) { productType = ProductArgs.scheme; - args = args.concat([ - "-destination", - "generic/platform=iOS Simulator", - "CODE_SIGNING_ALLOWED=NO", - ]); + args = args.concat(["CODE_SIGNING_ALLOWED=NO"]); } else { args = args.concat(["CODE_SIGN_IDENTITY="]); } args = args .concat([ + "-destination", + "generic/platform=iOS Simulator", "build", "-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug, @@ -83,6 +81,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService { projectData.projectName + ".xcarchive" ); const args = [ + "-destination", + "generic/platform=iOS", "archive", "-archivePath", archivePath, From 731d402ceb4640be71324cd6ba1c6bb478b9e8d9 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Fri, 3 Sep 2021 12:50:27 +0200 Subject: [PATCH 2/2] test: update tests --- test/services/ios/xcodebuild-args-service.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/services/ios/xcodebuild-args-service.ts b/test/services/ios/xcodebuild-args-service.ts index 85509988d9..0674b6b276 100644 --- a/test/services/ios/xcodebuild-args-service.ts +++ b/test/services/ios/xcodebuild-args-service.ts @@ -96,6 +96,8 @@ describe("xcodebuildArgsService", () => { const expectedArgs = [ "ONLY_ACTIVE_ARCH=NO", "CODE_SIGN_IDENTITY=", + "-destination", + "generic/platform=iOS Simulator", "build", "-configuration", configuration, @@ -170,6 +172,8 @@ describe("xcodebuildArgsService", () => { ); const expectedArgs = [ + "-destination", + "generic/platform=iOS", "archive", "-archivePath", path.join(buildOutputPath, `${projectName}.xcarchive`),