Ability to define a custom hook name #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jeremypele , |
|
Thanks @rosen-vladimirov that was quick! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a bunch of plugin and wanted to namespace them within my company name, the way
@angularor@ngxdoes.The issue I'm facing is that if I name my plugin
@mycompany/core,@mycompany/core.jswill not be a valid hook name (nesting issue) and breaks the installation.I'm adding the ability to define a
nameproperty on the hook definition inpackage.jsonso we can overwrite the default package name if required. (ex: naming the hook:mycompany-core.js)