-
Notifications
You must be signed in to change notification settings - Fork 128
Merge changes to the device abstraction ("EEG") class from my repo #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ErikBjare it appears to me that you have completed this or is there still more work to be done? |
@JadinTredup Nope, never got around to making a PR. I've made some pretty major changes, and working on a few more, almost to the point where I'm not sure if it makes sense to upstream it. But if it's of interest I'll consider it: https://github.com/ErikBjare/thesis/tree/master/src/eegwatch/devices |
@ErikBjare - what's your thoughts. Do you think these changes should be added or is divergence too great? |
@JohnGriffiths I'm not sure, I'd love it if you had a look at it and told me what you think. Code is here: https://github.com/ErikBjare/thesis/tree/master/src/eegwatch/devices Basically I created an abstract class I also implemented a Edit: Oh, and it also uses the bleak backend in muse-lsl by default (not yet merged upstream in muse-lsl afaik). |
@ErikBjare I am going to look this over today. Thank you so much for doing this. One of my biggest take aways from my internship development-wise has been implementing classes like this and so I was intending to do this at some point. |
@JohnGriffiths I like this a lot and think it improves our flexibility/scalability in the future. If you're okay with it I say we set up another branch and work on merging this. |
@JadinTredup Branch set up in #92, comments welcome! |
Uh oh!
There was an error while loading. Please reload this page.
My stuff is in: https://github.com/ErikBjare/thesis/blob/master/src/eegwatch/devices/
Includes a bunch of minor changes, including:
TODO
black eegnb/
#30)The text was updated successfully, but these errors were encountered: