Skip to content

Implement ratings prompt animations as designed #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iconix opened this issue Oct 11, 2016 · 1 comment
Closed

Implement ratings prompt animations as designed #93

iconix opened this issue Oct 11, 2016 · 1 comment
Assignees
@iconix
Labels
bug

Comments

@iconix
Copy link
Contributor

iconix commented Oct 11, 2016

Joshua spec'd really nice animations for the ratings prompt feature, but due to my own newness to motion design and our animations framework (Velocity.js), implementing them took a while.

We did not want to block shipping the feature, so I reused pre-existing Web Clipper animations to ship. This tracks replacing the temp animations with the shiny new ones.
@iconix iconix mentioned this issue Oct 11, 2016
Merged
@iconix iconix self-assigned this Oct 11, 2016
@iconix iconix added the bug label Oct 11, 2016
@iconix
Copy link
Contributor Author

iconix commented Oct 12, 2016

#76 merged

@iconix iconix closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iconix iconix

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iconix