Skip to content

Commit 8d2013e

Browse files
committed
Android plugin API updated to support v2 Embedding while remaining compatible with apps that don’t use the v2 Android embedding.
1 parent 96e6998 commit 8d2013e

23 files changed

+277
-176
lines changed

.gitignore

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,12 @@
66
pubspec.lock
77

88
build/
9-
.idea/
10-
android/.idea
9+
android/.idea
10+
.flutter-plugins-dependencies
11+
flutter_export_environment.sh
12+
13+
# IntelliJ related
14+
*.iml
15+
*.ipr
16+
*.iws
17+
.idea/

.idea/libraries/Dart_SDK.xml

Lines changed: 20 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/libraries/Flutter_for_Android.xml

Lines changed: 0 additions & 9 deletions
This file was deleted.

.idea/modules.xml

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/runConfigurations/example_lib_main_dart.xml

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/workspace.xml

Lines changed: 116 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ buildscript {
88
}
99

1010
dependencies {
11-
classpath 'com.android.tools.build:gradle:3.5.0'
11+
classpath 'com.android.tools.build:gradle:3.5.3'
1212
}
1313
}
1414

android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.2-all.zip

android/src/main/java/com/onesignal/flutter/FlutterRegistrarResponder.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
package com.onesignal.flutter;
22

3+
import android.content.Context;
34
import android.os.Handler;
45
import android.os.Looper;
56

67
import com.onesignal.OneSignal;
78

89
import java.util.HashMap;
910

11+
import io.flutter.plugin.common.BinaryMessenger;
1012
import io.flutter.plugin.common.MethodChannel;
1113
import io.flutter.plugin.common.PluginRegistry;
1214

1315
abstract class FlutterRegistrarResponder {
16+
Context context;
1417
MethodChannel channel;
15-
PluginRegistry.Registrar flutterRegistrar;
18+
BinaryMessenger messenger;
1619

1720
/**
1821
* MethodChannel class is home to success() method used by Result class

android/src/main/java/com/onesignal/flutter/OneSignalInAppMessagingController.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.Collection;
66
import java.util.Map;
77

8+
import io.flutter.plugin.common.BinaryMessenger;
89
import io.flutter.plugin.common.MethodCall;
910
import io.flutter.plugin.common.MethodChannel;
1011
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
@@ -14,11 +15,11 @@
1415
public class OneSignalInAppMessagingController extends FlutterRegistrarResponder implements MethodCallHandler {
1516
private MethodChannel channel;
1617

17-
static void registerWith(Registrar registrar) {
18+
static void registerWith(BinaryMessenger messenger) {
1819
OneSignalInAppMessagingController controller = new OneSignalInAppMessagingController();
19-
controller.channel = new MethodChannel(registrar.messenger(), "OneSignal#inAppMessages");
20+
controller.messenger = messenger;
21+
controller.channel = new MethodChannel(messenger, "OneSignal#inAppMessages");
2022
controller.channel.setMethodCallHandler(controller);
21-
controller.flutterRegistrar = registrar;
2223
}
2324

2425
@Override

android/src/main/java/com/onesignal/flutter/OneSignalOutcomeEventsController.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import java.util.HashMap;
77
import java.util.concurrent.atomic.AtomicBoolean;
88

9+
import io.flutter.plugin.common.BinaryMessenger;
910
import io.flutter.plugin.common.MethodCall;
1011
import io.flutter.plugin.common.MethodChannel;
1112
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
@@ -21,8 +22,8 @@ class OSFlutterOutcomeEventsHandler extends FlutterRegistrarResponder implements
2122
// this property guarantees the callback will never be called more than once.
2223
private AtomicBoolean replySubmitted = new AtomicBoolean(false);
2324

24-
OSFlutterOutcomeEventsHandler(PluginRegistry.Registrar flutterRegistrar, MethodChannel channel, Result result) {
25-
this.flutterRegistrar = flutterRegistrar;
25+
OSFlutterOutcomeEventsHandler(BinaryMessenger messenger, MethodChannel channel, Result result) {
26+
this.messenger = messenger;
2627
this.channel = channel;
2728
this.result = result;
2829
}
@@ -42,14 +43,12 @@ public void onSuccess(OSOutcomeEvent outcomeEvent) {
4243

4344
public class OneSignalOutcomeEventsController extends FlutterRegistrarResponder implements MethodCallHandler {
4445
private MethodChannel channel;
45-
private Registrar registrar;
4646

47-
static void registerWith(Registrar registrar) {
47+
static void registerWith(BinaryMessenger messenger) {
4848
OneSignalOutcomeEventsController controller = new OneSignalOutcomeEventsController();
49-
controller.registrar = registrar;
50-
controller.channel = new MethodChannel(registrar.messenger(), "OneSignal#outcomes");
49+
controller.messenger = messenger;
50+
controller.channel = new MethodChannel(messenger, "OneSignal#outcomes");
5151
controller.channel.setMethodCallHandler(controller);
52-
controller.flutterRegistrar = registrar;
5352
}
5453

5554
@Override
@@ -72,7 +71,7 @@ private void sendOutcome(MethodCall call, Result result) {
7271
return;
7372
}
7473

75-
OneSignal.sendOutcome(name, new OSFlutterOutcomeEventsHandler(registrar, channel, result));
74+
OneSignal.sendOutcome(name, new OSFlutterOutcomeEventsHandler(messenger, channel, result));
7675
}
7776

7877
private void sendUniqueOutcome(MethodCall call, Result result) {
@@ -83,7 +82,7 @@ private void sendUniqueOutcome(MethodCall call, Result result) {
8382
return;
8483
}
8584

86-
OneSignal.sendUniqueOutcome(name, new OSFlutterOutcomeEventsHandler(registrar, channel, result));
85+
OneSignal.sendUniqueOutcome(name, new OSFlutterOutcomeEventsHandler(messenger, channel, result));
8786
}
8887

8988
private void sendOutcomeWithValue(MethodCall call, Result result) {
@@ -100,7 +99,7 @@ private void sendOutcomeWithValue(MethodCall call, Result result) {
10099
return;
101100
}
102101

103-
OneSignal.sendOutcomeWithValue(name, value.floatValue(), new OSFlutterOutcomeEventsHandler(registrar, channel, result));
102+
OneSignal.sendOutcomeWithValue(name, value.floatValue(), new OSFlutterOutcomeEventsHandler(messenger, channel, result));
104103
}
105104

106105
}

0 commit comments

Comments
 (0)