Issue #668 just reuse ProcessListingResponse for UDPs

Author: soxofaan

openeo/rest/connection.py

@@ -70,7 +70,6 @@
     CollectionListingResponse,
     JobListingResponse,
     ProcessListingResponse,
-    UserDefinedProcessListingResponse,
 )
 from openeo.rest.service import Service
 from openeo.rest.udp import Parameter, RESTUserDefinedProcess
@@ -696,7 +695,7 @@ def list_collections(self) -> CollectionListingResponse:
         # TODO: add caching #383, but reset cache on auth change #254
         # TODO #677 add pagination support?
         data = self.get("/collections", expected_status=200).json()
-        return CollectionListingResponse(data)
+        return CollectionListingResponse(response_data=data)
 
     def list_collection_ids(self) -> List[str]:
         """
@@ -942,18 +941,18 @@ def save_user_defined_process(
         )
         return udp
 
-    def list_user_defined_processes(self) -> UserDefinedProcessListingResponse:
+    def list_user_defined_processes(self) -> ProcessListingResponse:
         """
         Lists all user-defined processes of the authenticated user.
 
         .. versionchanged:: 0.38.0
-            Returns a :py:class:`~openeo.rest.models.general.UserDefinedProcessListingResponse` object
+            Returns a :py:class:`~openeo.rest.models.general.ProcessListingResponse` object
             instead of a simple ``List[dict]``.
         """
         # TODO #677 add pagination support?
         self.assert_user_defined_process_support()
         data = self.get("/process_graphs", expected_status=200).json()
-        return UserDefinedProcessListingResponse(response_data=data)
+        return ProcessListingResponse(response_data=data)
 
     def user_defined_process(self, user_defined_process_id: str) -> RESTUserDefinedProcess:
         """

openeo/rest/models/general.py

@@ -112,51 +112,6 @@ def ext_federation(self) -> FederationExtension:
         return FederationExtension(self._data)
 
 
-class UserDefinedProcessListingResponse(list):
-    """
-    Container for process metadata listing received
-    from a ``GET /process_graphs`` request.
-
-    .. note::
-        This object mimics a simple list of collection metadata dictionaries,
-        which was the original return API of
-        :py:meth:`~openeo.rest.connection.Connection.list_user_defined_processes()`,
-        but now also provides methods/properties to access additional response data.
-
-    :param response_data: response data from a ``GET /process_graphs`` request
-
-    .. seealso:: :py:meth:`openeo.rest.connection.Connection.list_user_defined_processes()`
-
-    .. versionadded:: 0.38.0
-    """
-
-    # TODO: this is a copy of ProcessListingResponse, but with different class name
-
-    __slots__ = ["_data"]
-
-    def __init__(self, response_data: dict, *, warn_on_federation_missing: bool = True):
-        self._data = response_data
-        # Mimic original list of process metadata dictionaries
-        super().__init__(response_data["processes"])
-        if warn_on_federation_missing:
-            self.ext_federation.warn_on_missing(resource_name="process listing")
-
-    def _repr_html_(self):
-        return render_component(
-            component="processes", data=self, parameters={"show-graph": True, "provide-download": False}
-        )
-
-    @property
-    def links(self) -> List[Link]:
-        """Get links related to this resource."""
-        return [Link.from_dict(d) for d in self._data.get("links", [])]
-
-    @property
-    def ext_federation(self) -> FederationExtension:
-        """Accessor for federation extension data related to this resource."""
-        return FederationExtension(self._data)
-
-
 class JobListingResponse(list):
     """
     Container for job metadata listing received