Skip to content

Commit 756d510

Browse files
committed
Issue #391/#651 review tweaks
1 parent 8806613 commit 756d510

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

openeo/internal/graph_building.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,8 @@ class MultiLeafGraph(FlatGraphableMixin):
458458
Container for process graphs with multiple leaf/result nodes.
459459
"""
460460

461+
__slots__ = ["_leaves"]
462+
461463
def __init__(self, leaves: Iterable[FlatGraphableMixin]):
462464
self._leaves = list(leaves)
463465

openeo/rest/multiresult.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ class MultiResult(FlatGraphableMixin):
3434
.. versionadded:: 0.35.0
3535
"""
3636

37+
__slots__ = ("_multi_leaf_graph", "_connection")
38+
3739
def __init__(self, leaves: List[FlatGraphableMixin], connection: Optional[Connection] = None):
3840
"""
3941
Build a :py:class:`MultiResult` instance from multiple leaf nodes
@@ -47,11 +49,14 @@ def __init__(self, leaves: List[FlatGraphableMixin], connection: Optional[Connec
4749
are not already associated with a connection.
4850
"""
4951
self._multi_leaf_graph = MultiLeafGraph(leaves=leaves)
50-
self._connection = self._common_connection(leaves=leaves, connection=connection)
52+
self._connection = self._extract_connection(leaves=leaves, connection=connection)
5153

5254
@staticmethod
53-
def _common_connection(leaves: List[FlatGraphableMixin], connection: Optional[Connection] = None) -> Connection:
54-
"""Find common connection. Fails if there are multiple or none."""
55+
def _extract_connection(leaves: List[FlatGraphableMixin], connection: Optional[Connection] = None) -> Connection:
56+
"""
57+
Extract common connection from leaves and/or explicitly provided connection.
58+
Fails if there are multiple or none.
59+
"""
5560
connections = set()
5661
if connection:
5762
connections.add(connection)

0 commit comments

Comments
 (0)