Skip to content

Commit 1a1b604

Browse files
committed
fixup! PR #200 default to using "properties" dim name
1 parent 4c0d4c6 commit 1a1b604

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/test_vectorcube.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -188,20 +188,20 @@ def test_from_geodataframe_default(self, gdf):
188188
}
189189
)
190190
cube = vc.get_cube()
191-
assert cube.dims == ("geometries", "bands")
191+
assert cube.dims == ("geometries", "properties")
192192
assert cube.shape == (2, 1)
193-
assert {k: list(v.values) for k, v in cube.coords.items()} == {"geometries": [0, 1], "bands": ["pop"]}
193+
assert {k: list(v.values) for k, v in cube.coords.items()} == {"geometries": [0, 1], "properties": ["pop"]}
194194

195195
@pytest.mark.parametrize(
196196
["columns_for_cube", "expected"],
197197
[
198-
("numerical", {"shape": (2, 1), "coords": {"geometries": [0, 1], "bands": ["pop"]}}),
199-
("all", {"shape": (2, 2), "coords": {"geometries": [0, 1], "bands": ["id", "pop"]}}),
198+
("numerical", {"shape": (2, 1), "coords": {"geometries": [0, 1], "properties": ["pop"]}}),
199+
("all", {"shape": (2, 2), "coords": {"geometries": [0, 1], "properties": ["id", "pop"]}}),
200200
([], None),
201-
(["id"], {"shape": (2, 1), "coords": {"geometries": [0, 1], "bands": ["id"]}}),
202-
(["pop", "id"], {"shape": (2, 2), "coords": {"geometries": [0, 1], "bands": ["pop", "id"]}}),
201+
(["id"], {"shape": (2, 1), "coords": {"geometries": [0, 1], "properties": ["id"]}}),
202+
(["pop", "id"], {"shape": (2, 2), "coords": {"geometries": [0, 1], "properties": ["pop", "id"]}}),
203203
# TODO: test specifying non-existent column (to be filled with no-data):
204-
# (["pop", "nopenope"], {"shape": (2, 2), "coords": {"geometries": [0, 1], "bands": ["pop", "nopenope"]}}),
204+
# (["pop", "nopenope"], {"shape": (2, 2), "coords": {"geometries": [0, 1], "properties": ["pop", "nopenope"]}}),
205205
],
206206
)
207207
def test_from_geodataframe_columns_for_cube(self, gdf, columns_for_cube, expected):
@@ -237,7 +237,7 @@ def test_from_geodataframe_columns_for_cube(self, gdf, columns_for_cube, expecte
237237
if expected is None:
238238
assert cube is None
239239
else:
240-
assert cube.dims == ("geometries", "bands")
240+
assert cube.dims == ("geometries", "properties")
241241
assert cube.shape == expected["shape"]
242242
assert {k: list(v.values) for k, v in cube.coords.items()} == expected["coords"]
243243

0 commit comments

Comments
 (0)