Skip to content

Commit a692801

Browse files
committed
WIP
1 parent 1af1fdf commit a692801

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

openeo_driver/datacube.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,18 +605,21 @@ def apply_dimension(
605605
context: Optional[dict] = None,
606606
env: EvalEnv,
607607
) -> "DriverVectorCube":
608+
# Is callback a single run_udf node process?
608609
single_run_udf = SingleRunUDFProcessGraph.parse_or_none(process)
609610

610611
if single_run_udf:
611612
# Process with single "run_udf" node
612613
# TODO: check provided dimension with actual dimension of the cube
614+
# TODO: also support along geometries dim (e.g. when it's the only dim)?
613615
if dimension in (self.DIM_BANDS, self.DIM_PROPERTIES) and target_dimension is None:
614616
log.warning(
615617
f"Using experimental feature: DriverVectorCube.apply_dimension along dim {dimension} and empty cube"
616618
)
617-
# TODO: this is non-standard special case: vector cube with only geometries, but no "cube" data
619+
# TODO: data chunking (e.g. large feature collections)
618620
gdf = self._as_geopandas_df()
619621
feature_collection = openeo.udf.FeatureCollection(id="_", data=gdf)
622+
# TODO: dedicated UDF signature to indicate to work on vector cube through a feature collection based API
620623
udf_data = openeo.udf.UdfData(
621624
proj={"EPSG": self._geometries.crs.to_epsg()},
622625
feature_collection_list=[feature_collection],

0 commit comments

Comments
 (0)