Skip to content

Commit 23b0f6f

Browse files
committed
fix: add overwrite: true to overwrite on existing file
1 parent ee56b7b commit 23b0f6f

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

apps/generator-cli/src/app/services/version-manager.service.spec.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import { Test } from '@nestjs/testing';
2-
import { Version, VersionManagerService } from './version-manager.service';
3-
import { HttpService } from '@nestjs/common';
4-
import { of } from 'rxjs';
5-
import { mocked } from 'ts-jest/utils';
6-
import { LOGGER } from '../constants';
1+
import {Test} from '@nestjs/testing';
2+
import {Version, VersionManagerService} from './version-manager.service';
3+
import {HttpService} from '@nestjs/common';
4+
import {of} from 'rxjs';
5+
import {mocked} from 'ts-jest/utils';
6+
import {LOGGER} from '../constants';
77
import * as chalk from 'chalk';
8-
import { ConfigService } from './config.service';
9-
import { resolve } from 'path';
8+
import {ConfigService} from './config.service';
9+
import {resolve} from 'path';
1010
import * as os from 'os';
11-
import { TestingModule } from '@nestjs/testing/testing-module';
11+
import {TestingModule} from '@nestjs/testing/testing-module';
1212

1313
jest.mock('fs-extra');
1414
// eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -450,7 +450,7 @@ describe('VersionManagerService', () => {
450450
});
451451

452452
it('moves the file to the target location', () => {
453-
expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`);
453+
expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`, {overwrite: true});
454454
});
455455

456456
it('receives the data piped', () => {

apps/generator-cli/src/app/services/version-manager.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export class VersionManagerService {
116116
const file = fs.createWriteStream(temporaryFilePath);
117117
res.data.pipe(file);
118118
file.on('finish', content => {
119-
fs.moveSync(temporaryFilePath, filePath);
119+
fs.moveSync(temporaryFilePath, filePath, {overwrite: true});
120120
resolve(content);
121121
});
122122
})

0 commit comments

Comments
 (0)