Skip to content

[BUG] default basePath is different than in swagger-codegen #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomplus opened this issue Jan 19, 2019 · 2 comments
Closed

[BUG] default basePath is different than in swagger-codegen #1946

tomplus opened this issue Jan 19, 2019 · 2 comments
Milestone

Comments

@tomplus
Copy link
Member

tomplus commented Jan 19, 2019

Description

The openapi-generator has default basePath defined here:

but the swagger-codegen has https://localhost - the schema is different:

https://github.com/swagger-api/swagger-codegen/blob/c4c5c062cd25db43cd0aa93882560f278e6cd4f7/modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultGenerator.java#L103

Suggest a fix

Use default https://localhost as swagger-codegen - or update the migration guide.

@wing328
Copy link
Member

wing328 commented Jan 22, 2019

@tomplus thanks for reporting this. I'll update the migration guide accordingly.

@wing328 wing328 added this to the 4.0.0 milestone Jan 22, 2019
@wing328
Copy link
Member

wing328 commented Jan 23, 2019

Closed via #1957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants