Skip to content

Add dtype in loaders #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steinnymir opened this issue Oct 11, 2023 · 3 comments · Fixed by #329
Closed

Add dtype in loaders #172

steinnymir opened this issue Oct 11, 2023 · 3 comments · Fixed by #329

Comments

@steinnymir
Copy link
Member

Some columns are saved as float64 in raw data when this precision is not necessary. It might be beneficial to add a dtype option in the channels in the settings which tells which format to save the data to, and converting on readout.

This is particularly relevant for the FLASH Loader

@rettigl
Copy link
Member

rettigl commented Oct 11, 2023

This sounds like a good idea for saving space in the parquet files

@zain-sohail
Copy link
Member

I included this in the new PRs #329 and #330 (is the config model for loaders)

@zain-sohail zain-sohail linked a pull request Mar 20, 2024 that will close this issue
@rettigl
Copy link
Member

rettigl commented Jul 18, 2024

closed by #329 and #411

@rettigl rettigl closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants